You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "tuichenchuxin (via GitHub)" <gi...@apache.org> on 2023/02/24 10:05:25 UTC

[GitHub] [shardingsphere] tuichenchuxin opened a new pull request, #24343: Fix uppercase table constraint not rewrite exception.

tuichenchuxin opened a new pull request, #24343:
URL: https://github.com/apache/shardingsphere/pull/24343

   Fixes #24341.
   
   Changes proposed in this pull request:
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #24343: Fix uppercase table constraint not rewrite exception.

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24343:
URL: https://github.com/apache/shardingsphere/pull/24343#issuecomment-1443477298

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#24343](https://codecov.io/gh/apache/shardingsphere/pull/24343?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (987f199) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5fec520bb9884e6c81da67f9943e3f7828a76a97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fec520) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 987f199 differs from pull request most recent head 742e629. Consider uploading reports for the commit 742e629 to get more accurate results
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #24343   +/-   ##
   =========================================
     Coverage     50.05%   50.05%           
     Complexity     1584     1584           
   =========================================
     Files          3237     3237           
     Lines         53392    53393    +1     
     Branches       9847     9847           
   =========================================
   + Hits          26724    26725    +1     
     Misses        24290    24290           
     Partials       2378     2378           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/sharding/rewrite/token/pojo/ConstraintToken.java](https://codecov.io/gh/apache/shardingsphere/pull/24343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS90b2tlbi9wb2pvL0NvbnN0cmFpbnRUb2tlbi5qYXZh) | `100.00% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] sandynz merged pull request #24343: Fix uppercase table constraint not rewrite exception.

Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #24343:
URL: https://github.com/apache/shardingsphere/pull/24343


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org