You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mat Booth <ma...@wandisco.com> on 2011/10/14 16:42:50 UTC
Minor patch suggestion:
Hi all,
I'd like to suggest a trivial patch to make it easier to build
Subversion 1.7 on Windows with older Microsoft and non-Microsoft
compilers.
Please see attached.
It just applies the same pre-processor condition to the inclusion of
crtdbg.h as you already have for the use of functions from crtdbg.h.
Regards,
Mat
--
Mat Booth
Software Engineer
WANdisco, Inc.
http://www.wandisco.com
uberSVN: Subversion Made Easy
http://www.uberSVN.com
Everything you need to deploy Subversion in the Enterprise
http://www.wandisco.com/subversion
Subversion community
http://www.svnforum.org
Read our blogs
http://blogs.wandisco.com/
Follow us on Twitter
http://www.twitter.com/wandisco
THIS MESSAGE AND ANY ATTACHMENTS ARE CONFIDENTIAL, PROPRIETARY, AND
MAY BE PRIVILEGED. �If this message was misdirected, WANdisco, Inc.
and its subsidiaries, ("WANdisco") does not waive any confidentiality
or privilege. �If you are not the intended recipient, please notify us
immediately and destroy the message without disclosing its contents to
anyone. �Any distribution, use or copying of this e-mail or the
information it contains by other than an intended recipient is
unauthorized. �The views and opinions expressed in this e-mail message
are the author's own and may not reflect the views and opinions of
WANdisco, unless the author is authorized by WANdisco to express such
views or opinions on its behalf. �All email sent to or from this
address is subject to electronic storage and review by WANdisco.
Although WANdisco operates anti-virus programs, it does not accept
responsibility for any damage whatsoever caused by viruses being
passed.
RE: Minor patch suggestion:
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Mat Booth [mailto:mat.booth@wandisco.com]
> Sent: maandag 17 oktober 2011 12:26
> To: Peter Samuelson
> Cc: dev@subversion.apache.org
> Subject: Re: Minor patch suggestion:
>
> On 14 October 2011 18:25, Peter Samuelson <pe...@p12n.org> wrote:
> >
> > [Mat Booth]
> >> --- subversion/libsvn_subr/cmdline.c (revision 1183368)
> >> +++ subversion/libsvn_subr/cmdline.c (working copy)
> >> @@ -32,8 +32,10 @@
> >> #include <fcntl.h>
> >> #include <unistd.h>
> >> #else
> >> +#if _MSC_VER >= 1400
> >> #include <crtdbg.h>
> >> #endif
> >> +#endif
> >
> > Looks reasonable ... but then when I scrolled down the file a bit, I
> > found this:
> >
> > #if _MSC_VER >= 1400
> > /* ### This should work for VC++ 2002 (=1300) and later */
> >
> > So, what should it be? 1300 or 1400?
I just tested it for 1400 (Visual Studio 2005) and newer, because I have no
Visual Studio 2002 or 2003 installed. If somebody confirms that it works
correctly it should be enabled for that release, but now it just works as
before (I added that block) in that version.
I don't know anybody that still does real Subversion work with the 2002/2003
Visual Studio versions.
Visual Studio 2005, 2008 and 2010 are the most common releases and then
Visual C++ 6.0 (From 1998). But apache httpd and some other old projects
still require Visual C++ 6.0 (from 1998).
AnkhSVN has about 1000 users that still use Visual Studio 2002/2003. This
number is measurable in our update process, but nothing compared to our
total user base. (We have no numbers on VC 6.0 usage)
Bert
Re: Minor patch suggestion:
Posted by Mat Booth <ma...@wandisco.com>.
On 14 October 2011 18:25, Peter Samuelson <pe...@p12n.org> wrote:
>
> [Mat Booth]
>> --- subversion/libsvn_subr/cmdline.c (revision 1183368)
>> +++ subversion/libsvn_subr/cmdline.c (working copy)
>> @@ -32,8 +32,10 @@
>> #include <fcntl.h>
>> #include <unistd.h>
>> #else
>> +#if _MSC_VER >= 1400
>> #include <crtdbg.h>
>> #endif
>> +#endif
>
> Looks reasonable ... but then when I scrolled down the file a bit, I
> found this:
>
> #if _MSC_VER >= 1400
> /* ### This should work for VC++ 2002 (=1300) and later */
>
> So, what should it be? 1300 or 1400?
> --
> Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
>
Good question, I don't know. I don't have access to that compiler and
I didn't want to change it 1300 without testing it. Maybe rhuijben can
clairfy? (His name is on the svn blame for that line.)
--
Mat Booth
Software Engineer
WANdisco, Inc.
http://www.wandisco.com
uberSVN: Subversion Made Easy
http://www.uberSVN.com
Everything you need to deploy Subversion in the Enterprise
http://www.wandisco.com/subversion
Subversion community
http://www.svnforum.org
Read our blogs
http://blogs.wandisco.com/
Follow us on Twitter
http://www.twitter.com/wandisco
THIS MESSAGE AND ANY ATTACHMENTS ARE CONFIDENTIAL, PROPRIETARY, AND
MAY BE PRIVILEGED. If this message was misdirected, WANdisco, Inc.
and its subsidiaries, ("WANdisco") does not waive any confidentiality
or privilege. If you are not the intended recipient, please notify us
immediately and destroy the message without disclosing its contents to
anyone. Any distribution, use or copying of this e-mail or the
information it contains by other than an intended recipient is
unauthorized. The views and opinions expressed in this e-mail message
are the author's own and may not reflect the views and opinions of
WANdisco, unless the author is authorized by WANdisco to express such
views or opinions on its behalf. All email sent to or from this
address is subject to electronic storage and review by WANdisco.
Although WANdisco operates anti-virus programs, it does not accept
responsibility for any damage whatsoever caused by viruses being
passed.
Re: Minor patch suggestion:
Posted by Peter Samuelson <pe...@p12n.org>.
[Mat Booth]
> --- subversion/libsvn_subr/cmdline.c (revision 1183368)
> +++ subversion/libsvn_subr/cmdline.c (working copy)
> @@ -32,8 +32,10 @@
> #include <fcntl.h>
> #include <unistd.h>
> #else
> +#if _MSC_VER >= 1400
> #include <crtdbg.h>
> #endif
> +#endif
Looks reasonable ... but then when I scrolled down the file a bit, I
found this:
#if _MSC_VER >= 1400
/* ### This should work for VC++ 2002 (=1300) and later */
So, what should it be? 1300 or 1400?
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/