You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Xuefu Zhang <xz...@cloudera.com> on 2014/04/29 05:13:03 UTC
Review Request 20826: HIVE-5823: Support for DECIMAL primitive type in
AvroSerDe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20826/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-5823
https://issues.apache.org/jira/browse/HIVE-5823
Repository: hive-git
Description
-------
Support decimal type in Avro storage. The implemenation is based on specifications detailed in AVRO-1402.
Diffs
-----
data/files/dec.avro PRE-CREATION
data/files/dec.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java 52a22e5
ql/src/test/queries/clientpositive/avro_decimal.q PRE-CREATION
ql/src/test/queries/clientpositive/avro_schema_literal.q d77f310
ql/src/test/results/clientpositive/avro_decimal.q.out PRE-CREATION
ql/src/test/results/clientpositive/avro_schema_literal.q.out ca945d5
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java a28861f
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroGenericRecordWritable.java 8beffd7
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 92799ed
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java b2c58c7
serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 251f04f
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java b3559ea
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestGenericAvroRecordWritable.java a0e5018
serde/src/test/org/apache/hadoop/hive/serde2/avro/Utils.java d5730fa
Diff: https://reviews.apache.org/r/20826/diff/
Testing
-------
Unit tests are added. Test suite passed.
Thanks,
Xuefu Zhang
Re: Review Request 20826: HIVE-5823: Support for DECIMAL primitive type in
AvroSerDe
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20826/
-----------------------------------------------------------
(Updated May 4, 2014, 2:02 p.m.)
Review request for hive.
Bugs: HIVE-5823
https://issues.apache.org/jira/browse/HIVE-5823
Repository: hive-git
Description
-------
Support decimal type in Avro storage. The implemenation is based on specifications detailed in AVRO-1402.
Diffs (updated)
-----
data/files/dec.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java 52a22e5
ql/src/test/queries/clientpositive/avro_decimal.q PRE-CREATION
ql/src/test/queries/clientpositive/avro_schema_literal.q d77f310
ql/src/test/results/clientpositive/avro_decimal.q.out PRE-CREATION
ql/src/test/results/clientpositive/avro_schema_literal.q.out ca945d5
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java a28861f
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroGenericRecordWritable.java 8beffd7
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 92799ed
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java b2c58c7
serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 251f04f
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java b3559ea
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestGenericAvroRecordWritable.java a0e5018
serde/src/test/org/apache/hadoop/hive/serde2/avro/Utils.java d5730fa
Diff: https://reviews.apache.org/r/20826/diff/
Testing
-------
Unit tests are added. Test suite passed.
Thanks,
Xuefu Zhang
Re: Review Request 20826: HIVE-5823: Support for DECIMAL primitive type in
AvroSerDe
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20826/
-----------------------------------------------------------
(Updated May 3, 2014, 8:34 p.m.)
Review request for hive.
Bugs: HIVE-5823
https://issues.apache.org/jira/browse/HIVE-5823
Repository: hive-git
Description
-------
Support decimal type in Avro storage. The implemenation is based on specifications detailed in AVRO-1402.
Diffs (updated)
-----
data/files/dec.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java 52a22e5
ql/src/test/queries/clientpositive/avro_decimal.q PRE-CREATION
ql/src/test/queries/clientpositive/avro_schema_literal.q d77f310
ql/src/test/results/clientpositive/avro_decimal.q.out PRE-CREATION
ql/src/test/results/clientpositive/avro_schema_literal.q.out ca945d5
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java a28861f
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroGenericRecordWritable.java 8beffd7
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 92799ed
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java b2c58c7
serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 251f04f
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java b3559ea
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestGenericAvroRecordWritable.java a0e5018
serde/src/test/org/apache/hadoop/hive/serde2/avro/Utils.java d5730fa
Diff: https://reviews.apache.org/r/20826/diff/
Testing
-------
Unit tests are added. Test suite passed.
Thanks,
Xuefu Zhang
Re: Review Request 20826: HIVE-5823: Support for DECIMAL primitive type in
AvroSerDe
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20826/
-----------------------------------------------------------
(Updated May 3, 2014, 3:44 a.m.)
Review request for hive.
Bugs: HIVE-5823
https://issues.apache.org/jira/browse/HIVE-5823
Repository: hive-git
Description
-------
Support decimal type in Avro storage. The implemenation is based on specifications detailed in AVRO-1402.
Diffs (updated)
-----
data/files/dec.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java ecce21e
ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java 52a22e5
ql/src/test/queries/clientpositive/avro_decimal.q PRE-CREATION
ql/src/test/queries/clientpositive/avro_schema_literal.q d77f310
ql/src/test/results/clientpositive/avro_decimal.q.out PRE-CREATION
ql/src/test/results/clientpositive/avro_schema_literal.q.out ca945d5
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java a28861f
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroGenericRecordWritable.java 8beffd7
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 92799ed
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java b2c58c7
serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 251f04f
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java b3559ea
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestGenericAvroRecordWritable.java a0e5018
serde/src/test/org/apache/hadoop/hive/serde2/avro/Utils.java d5730fa
Diff: https://reviews.apache.org/r/20826/diff/
Testing
-------
Unit tests are added. Test suite passed.
Thanks,
Xuefu Zhang
Re: Review Request 20826: HIVE-5823: Support for DECIMAL primitive type in
AvroSerDe
Posted by Skye Wanderman-Milne <sk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20826/#review41889
-----------------------------------------------------------
ql/src/test/queries/clientpositive/avro_decimal.q
<https://reviews.apache.org/r/20826/#comment75549>
Here and below the "precison" and "scale" attributes should be JSON integers, not strings, as specified in the spec.
- Skye Wanderman-Milne
On April 29, 2014, 5:17 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20826/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 5:17 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5823
> https://issues.apache.org/jira/browse/HIVE-5823
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support decimal type in Avro storage. The implemenation is based on specifications detailed in AVRO-1402.
>
>
> Diffs
> -----
>
> data/files/dec.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java 52a22e5
> ql/src/test/queries/clientpositive/avro_decimal.q PRE-CREATION
> ql/src/test/queries/clientpositive/avro_schema_literal.q d77f310
> ql/src/test/results/clientpositive/avro_decimal.q.out PRE-CREATION
> ql/src/test/results/clientpositive/avro_schema_literal.q.out ca945d5
> serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java a28861f
> serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroGenericRecordWritable.java 8beffd7
> serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 92799ed
> serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13
> serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java b2c58c7
> serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 251f04f
> serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java b3559ea
> serde/src/test/org/apache/hadoop/hive/serde2/avro/TestGenericAvroRecordWritable.java a0e5018
> serde/src/test/org/apache/hadoop/hive/serde2/avro/Utils.java d5730fa
>
> Diff: https://reviews.apache.org/r/20826/diff/
>
>
> Testing
> -------
>
> Unit tests are added. Test suite passed.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 20826: HIVE-5823: Support for DECIMAL primitive type in
AvroSerDe
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20826/
-----------------------------------------------------------
(Updated April 29, 2014, 5:17 p.m.)
Review request for hive.
Bugs: HIVE-5823
https://issues.apache.org/jira/browse/HIVE-5823
Repository: hive-git
Description
-------
Support decimal type in Avro storage. The implemenation is based on specifications detailed in AVRO-1402.
Diffs (updated)
-----
data/files/dec.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java 52a22e5
ql/src/test/queries/clientpositive/avro_decimal.q PRE-CREATION
ql/src/test/queries/clientpositive/avro_schema_literal.q d77f310
ql/src/test/results/clientpositive/avro_decimal.q.out PRE-CREATION
ql/src/test/results/clientpositive/avro_schema_literal.q.out ca945d5
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java a28861f
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroGenericRecordWritable.java 8beffd7
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 92799ed
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java b2c58c7
serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 251f04f
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java b3559ea
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestGenericAvroRecordWritable.java a0e5018
serde/src/test/org/apache/hadoop/hive/serde2/avro/Utils.java d5730fa
Diff: https://reviews.apache.org/r/20826/diff/
Testing
-------
Unit tests are added. Test suite passed.
Thanks,
Xuefu Zhang