You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2010/11/01 14:08:35 UTC
svn commit: r1029637 -
/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/layout/Interval.java
Author: lofwyr
Date: Mon Nov 1 13:08:35 2010
New Revision: 1029637
URL: http://svn.apache.org/viewvc?rev=1029637&view=rev
Log:
TOBAGO-606: Add warning, when the config of the measures has logical errors.
Modified:
myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/layout/Interval.java
Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/layout/Interval.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/layout/Interval.java?rev=1029637&r1=1029636&r2=1029637&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/layout/Interval.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/layout/Interval.java Mon Nov 1 13:08:35 2010
@@ -20,10 +20,14 @@ package org.apache.myfaces.tobago.intern
import org.apache.myfaces.tobago.layout.LayoutComponent;
import org.apache.myfaces.tobago.layout.Measure;
import org.apache.myfaces.tobago.layout.Orientation;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class Interval {
+ private static final Logger LOG = LoggerFactory.getLogger(Interval.class);
+
private final Measure minimum;
private final Measure preferred;
@@ -41,6 +45,14 @@ public class Interval {
}
public Interval(Measure minimum, Measure preferred, Measure maximum, Measure current) {
+ if (LOG.isWarnEnabled()) {
+ if (minimum != null && minimum.greaterThan(preferred)) {
+ LOG.warn("Minimum '{}' is not smaller or equals preferred '{}'.", minimum, preferred);
+ }
+ if (preferred != null && preferred.greaterThan(maximum)) {
+ LOG.warn("Preferred '{}' is not smaller or equals maximum '{}'.", preferred, maximum);
+ }
+ }
this.minimum = minimum;
this.preferred = preferred;
this.maximum = maximum;