You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2010/02/16 11:15:28 UTC

[jira] Created: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module

[classlib] [imageio] Implement missing functionality in imageio module
----------------------------------------------------------------------

                 Key: HARMONY-6447
                 URL: https://issues.apache.org/jira/browse/HARMONY-6447
             Project: Harmony
          Issue Type: Task
          Components: Classlib
            Reporter: Mark Hindess


The imageio module has a significant amount of missing functionality in the javax.imageio, javax.imageio.spi and javax.imageio.stream packages.  See:

  http://people.apache.org/~hindessm/japi/sun50-hydrlvm50.html#pkg_javax_imageio

It is expected that an implementation and tests would be provided to complete this task.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849531#action_12849531 ] 

Hudson commented on HARMONY-6447:
---------------------------------

Integrated in Harmony-1.5-head-linux-x86_64 #732 (See [http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/732/])
    Applied patch from "[#] [classlib] [imageio] Implement missing
functionality in imageio module".  Fixed whitespace to remove spaces.


> [classlib] [imageio] Implement missing functionality in imageio module
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-6447
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6447
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Mark Hindess
>         Attachments: HARMONY-6447-yanglang.diff
>
>
> The imageio module has a significant amount of missing functionality in the javax.imageio, javax.imageio.spi and javax.imageio.stream packages.  See:
>   http://people.apache.org/~hindessm/japi/sun50-hydrlvm50.html#pkg_javax_imageio
> It is expected that an implementation and tests would be provided to complete this task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849518#action_12849518 ] 

Mark Hindess commented on HARMONY-6447:
---------------------------------------

I committed a minor change in r927216 to add the image/x-png mimetype so that the results of your new methods now match the RI behaviour with respect to the plugins we have implementations for in Harmony.

It might be easier to track any future patches as subtasks.  That is, create a new JIRA that describes the particular improvement and "Link" it to this one.  Thanks.


> [classlib] [imageio] Implement missing functionality in imageio module
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-6447
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6447
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Mark Hindess
>         Attachments: HARMONY-6447-yanglang.diff
>
>
> The imageio module has a significant amount of missing functionality in the javax.imageio, javax.imageio.spi and javax.imageio.stream packages.  See:
>   http://people.apache.org/~hindessm/japi/sun50-hydrlvm50.html#pkg_javax_imageio
> It is expected that an implementation and tests would be provided to complete this task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856342#action_12856342 ] 

Mark Hindess commented on HARMONY-6447:
---------------------------------------

Jeremias, thanks for the info.  The FOP tests will be really useful.  If you want to try harmony but don't want to setup your own harmony build, you can always grab the latest jdk from Hudson at:

  http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64/


> [classlib] [imageio] Implement missing functionality in imageio module
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-6447
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6447
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Mark Hindess
>         Attachments: HARMONY-6447-yanglang.diff
>
>
> The imageio module has a significant amount of missing functionality in the javax.imageio, javax.imageio.spi and javax.imageio.stream packages.  See:
>   http://people.apache.org/~hindessm/japi/sun50-hydrlvm50.html#pkg_javax_imageio
> It is expected that an implementation and tests would be provided to complete this task.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849511#action_12849511 ] 

Lang Yang commented on HARMONY-6447:
------------------------------------

Hi guys,

I have tested those four methods. The results returned are as follow:
GetReaderFormatNames == ["gif", "GIF", "png", "PNG", "jpeg", "jpg", "JPEG", "JPG"]
GetReaderMIMETypes == ["image/gif", "image/png", "image/jpeg"]

GetWriterFormatNames == ["png", "PNG", "jpeg", "jpg", "JPEG", "JPG"]
GetWriterMIMETypes == ["image/png", "image/jpeg"]

They seems identical with the registered reader/writer Spis:
        
        registerServiceProvider(new JPEGImageWriterSpi());
        registerServiceProvider(new JPEGImageReaderSpi());
        registerServiceProvider(new PNGImageReaderSpi());
        registerServiceProvider(new PNGImageWriterSpi());
        registerServiceProvider(new GIFImageReaderSpi());

Thanks,

Lang

> [classlib] [imageio] Implement missing functionality in imageio module
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-6447
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6447
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Mark Hindess
>         Attachments: HARMONY-6447-yanglang.diff
>
>
> The imageio module has a significant amount of missing functionality in the javax.imageio, javax.imageio.spi and javax.imageio.stream packages.  See:
>   http://people.apache.org/~hindessm/japi/sun50-hydrlvm50.html#pkg_javax_imageio
> It is expected that an implementation and tests would be provided to complete this task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857116#action_12857116 ] 

Lang Yang commented on HARMONY-6447:
------------------------------------

Hello Jeremias, Thanks for your suggestion. I will definitely take some time to look into FOP and test new functionalities on it. Hope ImageIO module won't be a problem to FOP in few months. 

> [classlib] [imageio] Implement missing functionality in imageio module
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-6447
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6447
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Mark Hindess
>         Attachments: HARMONY-6447-yanglang.diff
>
>
> The imageio module has a significant amount of missing functionality in the javax.imageio, javax.imageio.spi and javax.imageio.stream packages.  See:
>   http://people.apache.org/~hindessm/japi/sun50-hydrlvm50.html#pkg_javax_imageio
> It is expected that an implementation and tests would be provided to complete this task.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module

Posted by "Jeremias Maerki (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856339#action_12856339 ] 

Jeremias Maerki commented on HARMONY-6447:
------------------------------------------

I'm happy to see that there's something happening on this front. If I may make a suggestion: you can use a current Apache FOP release (0.95 or even trunk) to test the new additions. The gaps in ImageIO are one of the last blockers to make the latest FOP releases work on Harmony. I'll try to find time to test myself. I've never built Harmony myself, yet, but will still try to do that. I also have a large set of test images accumulated from my work on FOP. That should help identifying more exotic problems. See also: http://wiki.apache.org/harmony/Apache_FOP. I'll update that page once I've looked at this once more.

> [classlib] [imageio] Implement missing functionality in imageio module
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-6447
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6447
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Mark Hindess
>         Attachments: HARMONY-6447-yanglang.diff
>
>
> The imageio module has a significant amount of missing functionality in the javax.imageio, javax.imageio.spi and javax.imageio.stream packages.  See:
>   http://people.apache.org/~hindessm/japi/sun50-hydrlvm50.html#pkg_javax_imageio
> It is expected that an implementation and tests would be provided to complete this task.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6447:
-------------------------------

    Attachment: HARMONY-6447-yanglang.diff

Implemented 4 methods:
javax.imageio.ImageIO.getWriterFormatNames():
javax.imageio.ImageIO.getWriterMIMETypes():
javax.imageio.ImageIO.getReaderFormatNames():
javax.imageio.ImageIO.getReaderMIMETypes():

> [classlib] [imageio] Implement missing functionality in imageio module
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-6447
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6447
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Mark Hindess
>         Attachments: HARMONY-6447-yanglang.diff
>
>
> The imageio module has a significant amount of missing functionality in the javax.imageio, javax.imageio.spi and javax.imageio.stream packages.  See:
>   http://people.apache.org/~hindessm/japi/sun50-hydrlvm50.html#pkg_javax_imageio
> It is expected that an implementation and tests would be provided to complete this task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [general] layout (was: Re: [jira] Commented: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module)

Posted by Mark Hindess <ma...@googlemail.com>.
In message <4B...@gmail.com>, Tim Ellison writes:
>
> On 24/Mar/2010 22:59, Mark Hindess (JIRA) wrote:
> > Lang,  I've applied your patch in commit r927214.  Please confirm
> > that it has been applied as expected.  (For future reference,why try
> > to avoid tabs in Harmony code and prefer 4 tab indentation.  Please
> 
> of course, you meant "4 space" indentation.

Yes, I did.

Thanks,
 Mark.

> > set your editor accordingly if possible.)



[general] layout (was: Re: [jira] Commented: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module)

Posted by Tim Ellison <t....@gmail.com>.
On 24/Mar/2010 22:59, Mark Hindess (JIRA) wrote:
> Lang,  I've applied your patch in commit r927214.  Please confirm
> that it has been applied as expected.  (For future reference,why try
> to avoid tabs in Harmony code and prefer 4 tab indentation.  Please

of course, you meant "4 space" indentation.

> set your editor accordingly if possible.)


[jira] Commented: (HARMONY-6447) [classlib] [imageio] Implement missing functionality in imageio module

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849515#action_12849515 ] 

Mark Hindess commented on HARMONY-6447:
---------------------------------------

Lang,  I've applied your patch in commit r927214.  Please confirm that it has been applied as expected.  (For future reference,why try to avoid tabs in Harmony code and prefer 4 tab indentation.  Please set your editor accordingly if possible.)


> [classlib] [imageio] Implement missing functionality in imageio module
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-6447
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6447
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib
>            Reporter: Mark Hindess
>         Attachments: HARMONY-6447-yanglang.diff
>
>
> The imageio module has a significant amount of missing functionality in the javax.imageio, javax.imageio.spi and javax.imageio.stream packages.  See:
>   http://people.apache.org/~hindessm/japi/sun50-hydrlvm50.html#pkg_javax_imageio
> It is expected that an implementation and tests would be provided to complete this task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.