[GitHub] [hive] zabetak commented on a change in pull request #1331: HIVE-23946: Improve control flow and error handling in QTest dataset loading/unloading

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #1331:
URL: https://github.com/apache/hive/pull/1331#discussion_r464503259



##########
File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/dataset/QTestDatasetHandler.java
##########
@@ -52,8 +51,8 @@
 
   private File datasetDir;
   private static Set<String> srcTables;
-  private static Set<String> missingTables = new HashSet<>();

Review comment:
       Indeed there is a check-then-act race condition here. I was hoping to fix this without making `missingTables` and `tablesToUnload` static but looking at the code that I committed it seems that I screwed up something while I was rebasing :D I will address this in the following commits (hopefully :crossed_fingers: ). Thanks for catching this!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org