You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/02/01 02:46:14 UTC
Re: Review Request 42586: Defined the NetClsHandleMgr class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117171
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 37 - 38)
<https://reviews.apache.org/r/42586/#comment178256>
Add a blank line here
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 44)
<https://reviews.apache.org/r/42586/#comment178254>
s/issue/issues
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 88 - 89)
<https://reviews.apache.org/r/42586/#comment178257>
"A net_cls handle is composed of a 16-bit major and a 16-bit minor handle." This was already mentioned above for `NetClsHandle`
- Guangya Liu
On 一月 31, 2016, 5:45 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated 一月 31, 2016, 5:45 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On Feb. 1, 2016, 1:46 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 44
> > <https://reviews.apache.org/r/42586/diff/5/?file=1227352#file1227352line44>
> >
> > s/issue/issues
Thanks for catching this.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117171
-----------------------------------------------------------
On Jan. 31, 2016, 5:45 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 5:45 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>