You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by kg...@apache.org on 2025/08/29 09:13:15 UTC
(superset) branch fix/horizontal-layout-menu-color created (now 6b3e7731e0)
This is an automated email from the ASF dual-hosted git repository.
kgabryje pushed a change to branch fix/horizontal-layout-menu-color
in repository https://gitbox.apache.org/repos/asf/superset.git
at 6b3e7731e0 fix: Filter bar orientation submenu should not be highlighted
This branch includes the following new commits:
new 6b3e7731e0 fix: Filter bar orientation submenu should not be highlighted
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 01/01: fix: Filter bar orientation submenu should not be highlighted
Posted by kg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kgabryje pushed a commit to branch fix/horizontal-layout-menu-color
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 6b3e7731e0f13607f0a63644259bfae6923ff9b1
Author: Kamil Gabryjelski <ka...@gmail.com>
AuthorDate: Fri Aug 29 11:12:11 2025 +0200
fix: Filter bar orientation submenu should not be highlighted
---
.../nativeFilters/FilterBar/FilterBarSettings/index.tsx | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx
index ce5c3efd16..54f7810b6b 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx
@@ -190,6 +190,7 @@ const FilterBarSettings = () => {
items.push({
key: 'placement',
label: t('Orientation of filter bar'),
+ className: 'filter-bar-orientation-submenu',
children: [
{
key: FilterBarOrientation.Vertical,
@@ -200,9 +201,6 @@ const FilterBarSettings = () => {
FilterBarOrientation.Vertical && (
<Icons.CheckOutlined
iconColor={theme.colorPrimary}
- css={css`
- vertical-align: -${theme.sizeUnit * 0.03125}em;
- `}
iconSize="m"
/>
)}
@@ -252,6 +250,18 @@ const FilterBarSettings = () => {
selectedKeys: [selectedFilterBarOrientation],
}}
trigger={['click']}
+ popupRender={menu => (
+ <div
+ css={css`
+ .filter-bar-orientation-submenu.ant-dropdown-menu-submenu-selected
+ > .ant-dropdown-menu-submenu-title {
+ color: inherit;
+ }
+ `}
+ >
+ {menu}
+ </div>
+ )}
>
<Button
buttonStyle="link"