You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2015/10/09 22:10:43 UTC

[GitHub] couchdb-couch-epi pull request: Add couch_epi:decide/5

GitHub user iilyak opened a pull request:

    https://github.com/apache/couchdb-couch-epi/pull/15

    Add couch_epi:decide/5

    There are cases when we want to call configured providers until any of
    them would make a decision. We also would want to be able to find out
    if any decision has been made so we could call default handler.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch-epi feature/apply_while

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch-epi/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit baa484a83f99b2ddd6ade06ceabe631e6c06a9aa
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date:   2015-10-09T19:55:41Z

    Add couch_epi:decide/5
    
    There are cases when we want to call configured providers until any of
    them would make a decision. We also would want to be able to find out
    if any decision has been made so we could call default handler.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-epi pull request: Add couch_epi:decide/5

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-couch-epi/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-epi pull request: Add couch_epi:decide/5

Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-epi/pull/15#discussion_r41673057
  
    --- Diff: README.md ---
    @@ -97,6 +97,22 @@ Notes:
     
       - `concurrent` is incompatible with `pipe`
     
    +## decide functionality
    +
    +There are cases when we want to call configured providers until any of them
    +would make a decission. We also would want to be able to find out if any
    +decision has been made so we could call default handler. In order to be able
    +to do so there is couch_epi:decide/5. Every service which uses this feature
    +would get either:
    +
    +  - no_decision
    +  - {decided, Decission :: term()}
    --- End diff --
    
    s/Decission/Decision


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-epi pull request: Add couch_epi:decide/5

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-couch-epi/pull/15#issuecomment-148955838
  
    @rnewson LGFY?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-epi pull request: Add couch_epi:decide/5

Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:

    https://github.com/apache/couchdb-couch-epi/pull/15#issuecomment-151571275
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---