You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Leo Li (JIRA)" <ji...@apache.org> on 2006/08/18 11:50:16 UTC
[jira] Created: (HARMONY-1222)
[classlib][luni]org.apache.harmony.luni.platform.Environment fails to
recognize environment name case-incensitively on win32 platform.
[classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform.
--------------------------------------------------------------------------------------------------------------------------------------
Key: HARMONY-1222
URL: http://issues.apache.org/jira/browse/HARMONY-1222
Project: Harmony
Issue Type: Bug
Reporter: Leo Li
org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform, but RI does. RI accepts "PATH" the same as "path" on win32 but not on linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1222)
[classlib][luni]org.apache.harmony.luni.platform.Environment fails to
recognize environment name case-incensitively on win32 platform.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1222?page=all ]
Paulex Yang resolved HARMONY-1222.
----------------------------------
Resolution: Fixed
Leo, patch applied at revision r438040, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform.
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1222
> URL: http://issues.apache.org/jira/browse/HARMONY-1222
> Project: Harmony
> Issue Type: Bug
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.diff
>
>
> org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform, but RI does. RI accepts "PATH" the same as "path" on win32 but not on linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1222)
[classlib][luni]org.apache.harmony.luni.platform.Environment fails to
recognize environment name case-incensitively on win32 platform.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1222?page=comments#action_12429335 ]
Paulex Yang commented on HARMONY-1222:
--------------------------------------
Leo, I have some thoughts on this patch:
1. The patch used GetByteArrayRegion, but actually it always get the whole array, if the GetByteArrayElements or GetPrimitiveArrayCritical is used instead, there is chance not to copy the contents, so that the performance will be a little better.
2. Some variable(jbyteArray bytes) in the Windows natives is not used
3. Seems lpszVar in Windows natives needs to be freed explicitly?
4. I suggest to use hymem_allocate/free_memory to replace all the malloc/free, so that all native codes can have a unified memory management module.
Any problems, please let me know, thank you.
> [classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform.
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1222
> URL: http://issues.apache.org/jira/browse/HARMONY-1222
> Project: Harmony
> Issue Type: Bug
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff
>
>
> org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform, but RI does. RI accepts "PATH" the same as "path" on win32 but not on linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1222)
[classlib][luni]org.apache.harmony.luni.platform.Environment fails to
recognize environment name case-incensitively on win32 platform.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1222?page=all ]
Paulex Yang reassigned HARMONY-1222:
------------------------------------
Assignee: Paulex Yang
> [classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform.
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1222
> URL: http://issues.apache.org/jira/browse/HARMONY-1222
> Project: Harmony
> Issue Type: Bug
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff
>
>
> org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform, but RI does. RI accepts "PATH" the same as "path" on win32 but not on linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1222)
[classlib][luni]org.apache.harmony.luni.platform.Environment fails to
recognize environment name case-incensitively on win32 platform.
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1222?page=all ]
Leo Li updated HARMONY-1222:
----------------------------
Attachment: patch.diff
Hi, Paulex:
I have deleted useless variables and freed the environment string explicitly on windows since SetByteArrayRegion will copy the content of the buffer to the java byte array. Am I right?
As to GetByteArrayRegion, I need to copy it so as to transfer a java byte array to a null-terminated string. :)
Good luck!
> [classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform.
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1222
> URL: http://issues.apache.org/jira/browse/HARMONY-1222
> Project: Harmony
> Issue Type: Bug
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.diff
>
>
> org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform, but RI does. RI accepts "PATH" the same as "path" on win32 but not on linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1222)
[classlib][luni]org.apache.harmony.luni.platform.Environment fails to
recognize environment name case-incensitively on win32 platform.
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1222?page=comments#action_12436424 ]
Leo Li commented on HARMONY-1222:
---------------------------------
Verified. Sorry for the delay.
> [classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform.
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1222
> URL: http://issues.apache.org/jira/browse/HARMONY-1222
> Project: Harmony
> Issue Type: Bug
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.diff
>
>
> org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform, but RI does. RI accepts "PATH" the same as "path" on win32 but not on linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1222)
[classlib][luni]org.apache.harmony.luni.platform.Environment fails to
recognize environment name case-incensitively on win32 platform.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1222?page=all ]
Paulex Yang closed HARMONY-1222.
--------------------------------
Verified by Leo.
> [classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform.
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1222
> URL: http://issues.apache.org/jira/browse/HARMONY-1222
> Project: Harmony
> Issue Type: Bug
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.diff
>
>
> org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform, but RI does. RI accepts "PATH" the same as "path" on win32 but not on linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1222)
[classlib][luni]org.apache.harmony.luni.platform.Environment fails to
recognize environment name case-incensitively on win32 platform.
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1222?page=all ]
Leo Li updated HARMONY-1222:
----------------------------
Attachment: patch.diff
Hi,
will you pls try it?
> [classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform.
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1222
> URL: http://issues.apache.org/jira/browse/HARMONY-1222
> Project: Harmony
> Issue Type: Bug
> Reporter: Leo Li
> Attachments: patch.diff
>
>
> org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform, but RI does. RI accepts "PATH" the same as "path" on win32 but not on linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira