You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/21 18:22:49 UTC

[GitHub] piiswrong commented on a change in pull request #9933: [MXNET-23] Adding support to profile kvstore server during distributed training

piiswrong commented on a change in pull request #9933: [MXNET-23] Adding support to profile kvstore server during distributed training
URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r176190542
 
 

 ##########
 File path: python/mxnet/kvstore.py
 ##########
 @@ -613,6 +613,74 @@ def _send_command_to_servers(self, head, body):
         check_call(_LIB.MXKVStoreSendCommmandToServers(
             self.handle, mx_uint(head), c_str(body)))
 
+    def set_server_profiler_config(self, **kwargs):
 
 Review comment:
   I don't think these should be in KVStore class. Its better to put it in mxnet.profiler

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services