You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2026/04/15 07:03:05 UTC
[PR] server: fix lastpinged of hosts [cloudstack]
weizhouapache opened a new pull request, #13030:
URL: https://github.com/apache/cloudstack/pull/13030
### Description
This PR fixes the `lastpinged` in host response.
(note it shows the last time that the agent connected to management server, not the agent heartbeat time)
prior to the change
```
(localcloud) 🐱 > list hosts filter=lastpinged
{
"count": 4,
"host": [
{
"lastpinged": "1970-01-21T01:41:28+0000"
},
{
"lastpinged": "1970-01-21T01:41:28+0000"
},
{
"lastpinged": "1970-01-21T01:41:28+0000"
},
{
"lastpinged": "1970-01-21T01:41:39+0000"
}
]
}
```
with the change (another environment)
```
(localcloud) 🐱 > list hosts filter=lastpinged
{
"count": 4,
"host": [
{
"lastpinged": "2026-04-15T06:59:54+0000"
},
{
"lastpinged": "2026-04-09T08:25:45+0000"
},
{
"lastpinged": "2026-04-09T08:50:16+0000"
},
{
"lastpinged": "2026-04-09T08:50:17+0000"
}
]
}
```
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5190883937
> > I think it reflects the time of the last (re)connection of agent, rather than the last ping.
>
> ok, so do we make it an issue? not really a bug but a bit unclear and confusing.
I can add to UI
<img width="1174" height="259" alt="image" src="https://github.com/user-attachments/assets/8a3b5ffe-8b60-444e-84cd-18ef9e66caa6" />
what do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5191272611
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5190472165
tested ok,
one issue (unrelated to this PR I think)
```
(localcloud) 🐱 > list hosts filter=name,lastpinged
{
"count": 4,
"host": [
{
"lastpinged": "2026-08-05T09:15:18+0000",
"name": "pr13030-t16705-kvm-ol8-kvm1"
},
{
"lastpinged": "2026-08-05T05:01:44+0000",
"name": "pr13030-t16705-kvm-ol8-kvm2"
},
{
"lastpinged": "2026-08-05T08:55:57+0000",
"name": "s-333-VM"
},
{
"lastpinged": "2026-08-05T08:55:50+0000",
"name": "v-334-VM"
}
]
}
```
while `pr13030-t16705-kvm-ol8-kvm2` was pinged much more recently:
```
2026-08-05 10:05:05,213 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] (AgentManager-Handler-13:[]) (logid:) Ping from Routing host AgentAttache {"_id":2,"_name":"pr13030-t16705-kvm-ol8-kvm2","_uuid":"26b683ce-34d7-
4448-8634-91282c273081”}
```
and ..kvm1 as well btw;
```
2026-08-05 10:04:59,091 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] (AgentManager-Handler-10:[]) (logid:) Ping from Routing host AgentAttache {"_id":1,"_name":"pr13030-t16705-kvm-ol8-kvm1","_uuid":"f989b3eb-44dd-
4674-ab83-8814ac2b1ffe”}
```
I redid the `list hosts` again after retrieving the logs but the output is still identical. The unix time stamps in the DB seem more accurate:
```
The Unix timestamp 1744063788 corresponds to May 5, 2025, at 12:29:48 PM UTC.
The Unix timestamp 1744048930 corresponds to May 5, 2025, at 12:15:30 PM UTC.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5189980561
<b>[SF] Trillian test result (tid-16705)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53114 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13030-t16705-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5177753271
<b>[SF] Trillian Build Failed (tid-16699)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5190717563
> I think it reflects the time of the last (re)connection of agent, rather than the last ping.
ok, so do we make it an issue? not really a bug but a bit unclear and confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5191464310
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13030 (QA-JID-971)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5192729221
<img width="470" height="128" alt="Screenshot 2026-08-05 at 15 59 48" src="https://github.com/user-attachments/assets/78da8771-9437-4e87-8de3-be151da922be" />
qa shows the wrong timestamp :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5176269569
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5192770589
> <img width="470" height="128" alt="Screenshot 2026-08-05 at 15 59 48" src="https://github.com/user-attachments/assets/78da8771-9437-4e87-8de3-be151da922be" />
>
> qa shows the wrong timestamp :(
right...qa does not have the api fix..
it is good to test ui changes only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-4249998817
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13030?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 4.15%. Comparing base ([`8eb162c`](https://app.codecov.io/gh/apache/cloudstack/commit/8eb162cb996d2020447c1cdce69a43e04c0a5e69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`60fe960`](https://app.codecov.io/gh/apache/cloudstack/commit/60fe9602583c2ec103c2b2be05b79d6ee8b8a325?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (8eb162c) and HEAD (60fe960). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (8eb162c) | HEAD (60fe960) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.20 #13030 +/- ##
=============================================
- Coverage 16.26% 4.15% -12.11%
=============================================
Files 5665 404 -5261
Lines 500530 32966 -467564
Branches 60787 5893 -54894
=============================================
- Hits 81411 1370 -80041
+ Misses 410027 31420 -378607
+ Partials 9092 176 -8916
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13030/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.15% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/13030?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5176286968
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5177130141
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5177117160
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on code in PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#discussion_r3509995670
##########
server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java:
##########
@@ -126,7 +126,7 @@ private void setNewHostResponseBase(HostJoinVO host, EnumSet<HostDetails> detail
hostResponse.setHypervisor(hypervisorType);
}
hostResponse.setHostType(host.getType());
- hostResponse.setLastPinged(new Date(host.getLastPinged()));
+ hostResponse.setLastPinged(new Date(host.getLastPinged() << 10));
Review Comment:
@sureshanaparti these will not result in the same value.
`last_pinged` is shifted 10 bits to the right before being stored. See `ResourceManagerImpl#createHostVO` for instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#discussion_r3084604355
##########
server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java:
##########
@@ -126,7 +126,7 @@ private void setNewHostResponseBase(HostJoinVO host, EnumSet<HostDetails> detail
hostResponse.setHypervisor(hypervisorType);
}
hostResponse.setHostType(host.getType());
- hostResponse.setLastPinged(new Date(host.getLastPinged()));
+ hostResponse.setLastPinged(new Date(host.getLastPinged() << 10));
Review Comment:
```suggestion
hostResponse.setLastPinged(new Date(host.getLastPinged() * 1000));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5191123798
seems fine to me but I don’t see the last disconnected in the ui created from this version either.
Anyway let’s merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5191261361
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5175498839
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5175494956
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5175936570
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 18755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5177094384
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5190548556
> tested ok,
>
> one issue (unrelated to this PR I think)
>
> ```
> (localcloud) 🐱 > list hosts filter=name,lastpinged
> {
> "count": 4,
> "host": [
> {
> "lastpinged": "2026-08-05T09:15:18+0000",
> "name": "pr13030-t16705-kvm-ol8-kvm1"
> },
> {
> "lastpinged": "2026-08-05T05:01:44+0000",
> "name": "pr13030-t16705-kvm-ol8-kvm2"
> },
> {
> "lastpinged": "2026-08-05T08:55:57+0000",
> "name": "s-333-VM"
> },
> {
> "lastpinged": "2026-08-05T08:55:50+0000",
> "name": "v-334-VM"
> }
> ]
> }
> ```
>
> while `pr13030-t16705-kvm-ol8-kvm2` was pinged much more recently:
>
> ```
> 2026-08-05 10:05:05,213 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] (AgentManager-Handler-13:[]) (logid:) Ping from Routing host AgentAttache {"_id":2,"_name":"pr13030-t16705-kvm-ol8-kvm2","_uuid":"26b683ce-34d7-
> 4448-8634-91282c273081”}
> ```
>
> and ..kvm1 as well btw;
>
> ```
> 2026-08-05 10:04:59,091 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] (AgentManager-Handler-10:[]) (logid:) Ping from Routing host AgentAttache {"_id":1,"_name":"pr13030-t16705-kvm-ol8-kvm1","_uuid":"f989b3eb-44dd-
> 4674-ab83-8814ac2b1ffe”}
> ```
>
> I redid the `list hosts` again after retrieving the logs but the output is still identical. The unix time stamps in the DB seem more accurate:
>
> ```
> The Unix timestamp 1744063788 corresponds to May 5, 2025, at 12:29:48 PM UTC.
> The Unix timestamp 1744048930 corresponds to May 5, 2025, at 12:15:30 PM UTC.
> ```
@DaanHoogland
I think it reflects the time of the last (re)connection of agent, rather than the last ping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix lastpinged of hosts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13030:
URL: https://github.com/apache/cloudstack/pull/13030#issuecomment-5192852143
> > <img alt="Screenshot 2026-08-05 at 15 59 48" width="470" height="128" src="https://private-user-images.githubusercontent.com/2486961/631800024-78da8771-9437-4e87-8de3-be151da922be.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODU5MzkyODQsIm5iZiI6MTc4NTkzODk4NCwicGF0aCI6Ii8yNDg2OTYxLzYzMTgwMDAyNC03OGRhODc3MS05NDM3LTRlODctOGRlMy1iZTE1MWRhOTIyYmUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDgwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA4MDVUMTQwOTQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmIyZTk3MzEwOGQ2NzA5OTg5YTE5ZTBmNzQyZTZkZjM5N2Q2M2Y1MDRhNzYwMWNhZjMyMTRiM2VjOWE0MWJhNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.qwBfwlYa4kxyqmU8_M1Drc1fPC85plVono3j55KXA5w">
> > qa shows the wrong timestamp :(
>
> right...qa does not have the api fix.. it is good to test ui changes only.
at least both changes are validated independently. I settle ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org