[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #822: MINIFICPP-1253 - Do not hang on full cycles

[GitBox <gi...@apache.org>]

adamdebreceni commented on a change in pull request #822:
URL: https://github.com/apache/nifi-minifi-cpp/pull/822#discussion_r450869926



##########
File path: libminifi/include/core/Processor.h
##########
@@ -305,6 +311,19 @@ class Processor : public Connectable, public ConfigurableComponent, public std::
   Processor &operator=(const Processor &parent);
 
  private:
+  static std::mutex& getGraphMutex() {
+    static std::mutex mutex{};
+    return mutex;
+  }
+
+  // must hold the graphMutex
+  void updateReachability(const std::lock_guard<std::mutex>& graph_lock, bool force = false);

Review comment:
       if it turns out that there is a legit use-case where we would need to expose this method, I'm more than happy to make it non-private but I couldn't come up with a reason to do so




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org