You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by bd...@apache.org on 2008/05/27 23:27:32 UTC
svn commit: r660714 -
/incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java
Author: bdelacretaz
Date: Tue May 27 14:27:31 2008
New Revision: 660714
URL: http://svn.apache.org/viewvc?rev=660714&view=rev
Log:
Change @scr.component ds attribute to scr - not sure what this means but JSP engine doesn't work for me with ds
Modified:
incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java
Modified: incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java
URL: http://svn.apache.org/viewvc/incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java?rev=660714&r1=660713&r2=660714&view=diff
==============================================================================
--- incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java (original)
+++ incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java Tue May 27 14:27:31 2008
@@ -49,7 +49,7 @@
/**
* The JSP engine (a.k.a Jasper).
*
- * @scr.component ds="no" label="%jsphandler.name"
+ * @scr.component scr="no" label="%jsphandler.name"
* description="%jsphandler.description"
* @scr.property name="service.description" value="JSP Script Handler"
* @scr.property name="service.vendor" value="The Apache Software Foundation" *
Re: svn commit: r660714 -
/incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
Am Mittwoch, den 28.05.2008, 13:40 +0200 schrieb Bertrand Delacretaz:
> On Wed, May 28, 2008 at 1:09 PM, Felix Meschberger
> <Fe...@day.com> wrote:
> > ...I changed that yesterday, as I thought the intention was to disable the
> > generation of the Declarative Services descriptor....
>
> http://felix.apache.org/site/maven-scr-plugin.html does not mention
> the scr attribute anymore, has it been renamed to ds? I'm a bit
> confused.
>
> If so that would mean that, in
>
> >> + * @scr.component scr="no" label="%jsphandler.name"
>
> the scr="no" attribute has no effect.
Exactly. I am equally confused. ;-) I have removed that attribute now,
it is not used and just causes confusion.
Regards
Felix
Re: svn commit: r660714 - /incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, May 28, 2008 at 1:09 PM, Felix Meschberger
<Fe...@day.com> wrote:
> ...I changed that yesterday, as I thought the intention was to disable the
> generation of the Declarative Services descriptor....
http://felix.apache.org/site/maven-scr-plugin.html does not mention
the scr attribute anymore, has it been renamed to ds? I'm a bit
confused.
If so that would mean that, in
>> + * @scr.component scr="no" label="%jsphandler.name"
the scr="no" attribute has no effect.
-Bertrand
Re: svn commit: r660714 -
/incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java
Posted by Felix Meschberger <Fe...@day.com>.
Oops,
I changed that yesterday, as I thought the intention was to disable the
generation of the Declarative Services descriptor. Obviously the
descriptor is actually needed. Thanks for fixing.
Regards
Felix
Am Dienstag, den 27.05.2008, 21:27 +0000 schrieb bdelacretaz@apache.org:
> Author: bdelacretaz
> Date: Tue May 27 14:27:31 2008
> New Revision: 660714
>
> URL: http://svn.apache.org/viewvc?rev=660714&view=rev
> Log:
> Change @scr.component ds attribute to scr - not sure what this means but JSP engine doesn't work for me with ds
>
> Modified:
> incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java
>
> Modified: incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java
> URL: http://svn.apache.org/viewvc/incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java?rev=660714&r1=660713&r2=660714&view=diff
> ==============================================================================
> --- incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java (original)
> +++ incubator/sling/trunk/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/JspScriptEngineFactory.java Tue May 27 14:27:31 2008
> @@ -49,7 +49,7 @@
> /**
> * The JSP engine (a.k.a Jasper).
> *
> - * @scr.component ds="no" label="%jsphandler.name"
> + * @scr.component scr="no" label="%jsphandler.name"
> * description="%jsphandler.description"
> * @scr.property name="service.description" value="JSP Script Handler"
> * @scr.property name="service.vendor" value="The Apache Software Foundation" *
>
>
--
Visit: http://dev.day.com/ - Day JCR Cup 08 - Win a MacBook Pro