You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Nanda kumar (Jira)" <ji...@apache.org> on 2020/06/09 08:22:00 UTC
[jira] [Commented] (HDDS-3754) Rename framework to common-server
[ https://issues.apache.org/jira/browse/HDDS-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128988#comment-17128988 ]
Nanda kumar commented on HDDS-3754:
-----------------------------------
[~elek], thanks for proposing this.
It makes sense to rename {{container-service}} to {{datanode}}, but I would suggest having the submodule inside {{hadoop-ozone/hadoop-hdds}}. For me, {{datanode}} is part of {{hdds}} service.
Ozone codebase has two subproject
1) HDDS - Hadoop Distributed Data Store
2) Ozone - Object Store implementation which uses HDDS
If we consider this, {{container-service}} or {{datanode}} should be inside {{hadoop-ozone/hadoop-hdds}}.
About renaming {{framework}} to {{server-common}}, I'm not very much convinced on this.
Having {{framework}} subproject makes sense as it can provide
* Lock service/framework
* Lease service/framework
* Security service/framework
* EventQueue service/framework
...
Which can be used by other modules.
{{Common}} project is a collection of reusable code or utilities which is used by other modules, but with {{framework}} we can have a clear interface defined which can expose generic services. I agree that the current code is not in this state yet, but we can always improve.
I don't have any other strong points on the {{framework}} rename. I'm not against it, just registering my opinion.
> Rename framework to common-server
> ---------------------------------
>
> Key: HDDS-3754
> URL: https://issues.apache.org/jira/browse/HDDS-3754
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Marton Elek
> Assignee: Marton Elek
> Priority: Major
>
> I started to document the project hierarchy of Ozone and found that to subproject name is very confusing:
>
> 1. framework: it supposed to be similar to the common but share the classes only between server side projects (om/scm/...). I propose to call it server-common
> 2. container-service: While we have historical reasons why it's a separated project, but today we can call it datanode and remove hadoop-ozone/datanode.
>
> While I can learn both the specific names, for new contributors it can help if we use more straightforward names.
> In this patch I would like to fix the first item (framework --> common-server)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org