You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/28 05:57:18 UTC

[GitHub] [iceberg] nastra commented on a diff in pull request #5368: AWS: Fix/Suppress ErrorProne warnings

nastra commented on code in PR #5368:
URL: https://github.com/apache/iceberg/pull/5368#discussion_r931809349


##########
aws/src/integration/java/org/apache/iceberg/aws/lakeformation/TestLakeFormationMetadataOperations.java:
##########
@@ -241,7 +241,7 @@ public void testAlterTableSetPropertiesNoDataPathAccess() {
       AssertHelpers.assertThrows("attempt to alter a table without ALTER permission should fail",
           ForbiddenException.class,
           "Glue cannot access the requested resources",
-          () -> updateProperties.commit());

Review Comment:
   ```
   /...iceberg/aws/src/integration/java/org/apache/iceberg/aws/lakeformation/TestLakeFormationMetadataOperations.java:244: warning: [LambdaMethodReference] Lambda should be a method reference
             () -> updateProperties.commit());
             ^
       (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org