You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Andrei Pozolotin (JIRA)" <ji...@apache.org> on 2012/09/20 23:56:07 UTC
[jira] [Created] (KARAF-1851) inconsistent FeaturesNamespaces
versions
Andrei Pozolotin created KARAF-1851:
---------------------------------------
Summary: inconsistent FeaturesNamespaces versions
Key: KARAF-1851
URL: https://issues.apache.org/jira/browse/KARAF-1851
Project: Karaf
Issue Type: Bug
Components: karaf-feature
Reporter: Andrei Pozolotin
should this be same version number 1.2.0?
String URI_CURRENT = URI_1_2_0;
QName FEATURES_CURRENT = FEATURES_1_1_0;
################################################
public interface FeaturesNamespaces {
String URI_0_0_0 = "";
String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
String URI_CURRENT = URI_1_2_0;
QName FEATURES_0_0_0 = new QName("features");
QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
QName FEATURES_CURRENT = FEATURES_1_1_0;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1851) inconsistent FeaturesNamespaces
versions
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460007#comment-13460007 ]
Andrei Pozolotin commented on KARAF-1851:
-----------------------------------------
FeatureDeploymentListener
also needs new version entry here:
{code}
private boolean isKnownFeaturesURI(String uri){
if(uri == null){
return true;
}
if(FeaturesNamespaces.URI_0_0_0.equalsIgnoreCase(uri)){
return true;
}
if(FeaturesNamespaces.URI_1_0_0.equalsIgnoreCase(uri)){
return true;
}
if(FeaturesNamespaces.URI_1_1_0.equalsIgnoreCase(uri)){
return true;
}
if(FeaturesNamespaces.URI_CURRENT.equalsIgnoreCase(uri)){
return true;
}
return false;
}
{code}
> inconsistent FeaturesNamespaces versions
> ----------------------------------------
>
> Key: KARAF-1851
> URL: https://issues.apache.org/jira/browse/KARAF-1851
> Project: Karaf
> Issue Type: Bug
> Components: karaf-feature
> Reporter: Andrei Pozolotin
>
> should this be same version number 1.2.0?
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> ################################################
> {code}
> public interface FeaturesNamespaces {
> String URI_0_0_0 = "";
> String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
> String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
> String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_0_0_0 = new QName("features");
> QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
> QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
> QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1851) inconsistent FeaturesNamespaces
versions
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460012#comment-13460012 ]
Andrei Pozolotin commented on KARAF-1851:
-----------------------------------------
it seems Ioannis Canellos is the appropriate expert to take a look on this.
> inconsistent FeaturesNamespaces versions
> ----------------------------------------
>
> Key: KARAF-1851
> URL: https://issues.apache.org/jira/browse/KARAF-1851
> Project: Karaf
> Issue Type: Bug
> Components: karaf-feature
> Reporter: Andrei Pozolotin
>
> should this be same version number 1.2.0?
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> ################################################
> {code}
> public interface FeaturesNamespaces {
> String URI_0_0_0 = "";
> String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
> String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
> String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_0_0_0 = new QName("features");
> QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
> QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
> QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1851) inconsistent FeaturesNamespaces
versions
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463931#comment-13463931 ]
Andrei Pozolotin commented on KARAF-1851:
-----------------------------------------
ok, will do. thanks for looking.
> inconsistent FeaturesNamespaces versions
> ----------------------------------------
>
> Key: KARAF-1851
> URL: https://issues.apache.org/jira/browse/KARAF-1851
> Project: Karaf
> Issue Type: Bug
> Components: karaf-feature
> Reporter: Andrei Pozolotin
> Assignee: Ioannis Canellos
>
> should this be same version number 1.2.0?
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> ################################################
> {code}
> public interface FeaturesNamespaces {
> String URI_0_0_0 = "";
> String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
> String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
> String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_0_0_0 = new QName("features");
> QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
> QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
> QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KARAF-1851) inconsistent
FeaturesNamespaces versions
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460008#comment-13460008 ]
Andrei Pozolotin edited comment on KARAF-1851 at 9/21/12 9:19 AM:
------------------------------------------------------------------
and this should not use hard coded literal:
instead use FeaturesNamespaces.URI_CURRENT
{code}
@javax.xml.bind.annotation.XmlSchema(namespace = "http://karaf.apache.org/xmlns/features/v1.2.0", elementFormDefault = javax.xml.bind.annotation.XmlNsForm.QUALIFIED)
package org.apache.karaf.features.internal.model;
import org.apache.karaf.features.FeaturesNamespaces;
{code}
was (Author: andrei.pozolotin):
and this should not use hard coded literal:
instead use FeaturesNamespaces.FeaturesNamespaces
{code}
@javax.xml.bind.annotation.XmlSchema(namespace = "http://karaf.apache.org/xmlns/features/v1.2.0", elementFormDefault = javax.xml.bind.annotation.XmlNsForm.QUALIFIED)
package org.apache.karaf.features.internal.model;
import org.apache.karaf.features.FeaturesNamespaces;
{code}
> inconsistent FeaturesNamespaces versions
> ----------------------------------------
>
> Key: KARAF-1851
> URL: https://issues.apache.org/jira/browse/KARAF-1851
> Project: Karaf
> Issue Type: Bug
> Components: karaf-feature
> Reporter: Andrei Pozolotin
>
> should this be same version number 1.2.0?
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> ################################################
> {code}
> public interface FeaturesNamespaces {
> String URI_0_0_0 = "";
> String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
> String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
> String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_0_0_0 = new QName("features");
> QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
> QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
> QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-1851) inconsistent FeaturesNamespaces
versions
Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ioannis Canellos reassigned KARAF-1851:
---------------------------------------
Assignee: Ioannis Canellos
> inconsistent FeaturesNamespaces versions
> ----------------------------------------
>
> Key: KARAF-1851
> URL: https://issues.apache.org/jira/browse/KARAF-1851
> Project: Karaf
> Issue Type: Bug
> Components: karaf-feature
> Reporter: Andrei Pozolotin
> Assignee: Ioannis Canellos
>
> should this be same version number 1.2.0?
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> ################################################
> {code}
> public interface FeaturesNamespaces {
> String URI_0_0_0 = "";
> String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
> String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
> String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_0_0_0 = new QName("features");
> QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
> QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
> QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1851) inconsistent FeaturesNamespaces
versions
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Pozolotin updated KARAF-1851:
------------------------------------
Description:
should this be same version number 1.2.0?
String URI_CURRENT = URI_1_2_0;
QName FEATURES_CURRENT = FEATURES_1_1_0;
################################################
{code}
public interface FeaturesNamespaces {
String URI_0_0_0 = "";
String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
String URI_CURRENT = URI_1_2_0;
QName FEATURES_0_0_0 = new QName("features");
QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
QName FEATURES_CURRENT = FEATURES_1_1_0;
}
{code}
was:
should this be same version number 1.2.0?
String URI_CURRENT = URI_1_2_0;
QName FEATURES_CURRENT = FEATURES_1_1_0;
################################################
public interface FeaturesNamespaces {
String URI_0_0_0 = "";
String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
String URI_CURRENT = URI_1_2_0;
QName FEATURES_0_0_0 = new QName("features");
QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
QName FEATURES_CURRENT = FEATURES_1_1_0;
}
> inconsistent FeaturesNamespaces versions
> ----------------------------------------
>
> Key: KARAF-1851
> URL: https://issues.apache.org/jira/browse/KARAF-1851
> Project: Karaf
> Issue Type: Bug
> Components: karaf-feature
> Reporter: Andrei Pozolotin
>
> should this be same version number 1.2.0?
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> ################################################
> {code}
> public interface FeaturesNamespaces {
> String URI_0_0_0 = "";
> String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
> String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
> String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_0_0_0 = new QName("features");
> QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
> QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
> QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1851) inconsistent FeaturesNamespaces
versions
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460008#comment-13460008 ]
Andrei Pozolotin commented on KARAF-1851:
-----------------------------------------
and this should not use hard coded literal:
instead use FeaturesNamespaces.FeaturesNamespaces
{code}
@javax.xml.bind.annotation.XmlSchema(namespace = "http://karaf.apache.org/xmlns/features/v1.2.0", elementFormDefault = javax.xml.bind.annotation.XmlNsForm.QUALIFIED)
package org.apache.karaf.features.internal.model;
import org.apache.karaf.features.FeaturesNamespaces;
{code}
> inconsistent FeaturesNamespaces versions
> ----------------------------------------
>
> Key: KARAF-1851
> URL: https://issues.apache.org/jira/browse/KARAF-1851
> Project: Karaf
> Issue Type: Bug
> Components: karaf-feature
> Reporter: Andrei Pozolotin
>
> should this be same version number 1.2.0?
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> ################################################
> {code}
> public interface FeaturesNamespaces {
> String URI_0_0_0 = "";
> String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
> String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
> String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_0_0_0 = new QName("features");
> QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
> QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
> QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1851) inconsistent FeaturesNamespaces
versions
Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463601#comment-13463601 ]
Ioannis Canellos commented on KARAF-1851:
-----------------------------------------
Andrei,
I think that you are right. Do you want to provide a patch for it?
> inconsistent FeaturesNamespaces versions
> ----------------------------------------
>
> Key: KARAF-1851
> URL: https://issues.apache.org/jira/browse/KARAF-1851
> Project: Karaf
> Issue Type: Bug
> Components: karaf-feature
> Reporter: Andrei Pozolotin
> Assignee: Ioannis Canellos
>
> should this be same version number 1.2.0?
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> ################################################
> {code}
> public interface FeaturesNamespaces {
> String URI_0_0_0 = "";
> String URI_1_0_0 = "http://karaf.apache.org/xmlns/features/v1.0.0";
> String URI_1_1_0 = "http://karaf.apache.org/xmlns/features/v1.1.0";
> String URI_1_2_0 = "http://karaf.apache.org/xmlns/features/v1.2.0";
> String URI_CURRENT = URI_1_2_0;
> QName FEATURES_0_0_0 = new QName("features");
> QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
> QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");
> QName FEATURES_1_2_0 = new QName(URI_1_2_0, "features");
> QName FEATURES_CURRENT = FEATURES_1_1_0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira