You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2012/10/01 21:41:07 UTC
[jira] [Commented] (THRIFT-1645) Replace Object#tee with more
conventional Object#tap in specs
[ https://issues.apache.org/jira/browse/THRIFT-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467131#comment-13467131 ]
Hudson commented on THRIFT-1645:
--------------------------------
Integrated in Thrift #541 (See [https://builds.apache.org/job/Thrift/541/])
THRIFT-1645: Replace Object#tee with more conventional Object#tap in specs
Client: rb
Patch: Nathan Beyer
The spec_helper.rb defines an Object#tee method, which is functionally equivalent to Object#tap. Object#tap was added to Ruby 1.9 and to 1.8.7. (Revision 1392509)
Result = FAILURE
jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1392509
Files :
* /thrift/trunk/lib/rb/spec/client_spec.rb
* /thrift/trunk/lib/rb/spec/http_client_spec.rb
* /thrift/trunk/lib/rb/spec/mongrel_http_server_spec.rb
* /thrift/trunk/lib/rb/spec/processor_spec.rb
* /thrift/trunk/lib/rb/spec/spec_helper.rb
> Replace Object#tee with more conventional Object#tap in specs
> -------------------------------------------------------------
>
> Key: THRIFT-1645
> URL: https://issues.apache.org/jira/browse/THRIFT-1645
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Reporter: Nathan Beyer
> Assignee: Nathan Beyer
> Fix For: 0.9
>
> Attachments: THRIFT-1645-replace-tee-with-tap.patch, THRIFT-1645-replace-tee-with-tap-v2.patch
>
>
> The spec_helper.rb defines an Object#tee method, which is functionally equivalent to Object#tap. Object#tap was added to Ruby 1.9 and to 1.8.7.
> Attached is a patch that replaces the usage of 'tee' with 'tap' and will define the 'tap' method if it's missing (should only happen when Ruby 1.8.6 or below is used). If there's no need to support such a low minimum, this could be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira