You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/15 15:34:12 UTC
[GitHub] [skywalking-banyandb] hanahmily opened a new pull request #46: Implements LSM tree index and inverted index
hanahmily opened a new pull request #46:
URL: https://github.com/apache/skywalking-banyandb/pull/46
These changes implemented all kinds of index which will be used in 0.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng merged pull request #46: Implements LSM tree index and inverted index
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #46:
URL: https://github.com/apache/skywalking-banyandb/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #46: Implements LSM tree index and inverted index
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #46:
URL: https://github.com/apache/skywalking-banyandb/pull/46#issuecomment-920664099
> There seems to be many codes commented out, not sure it's temporary or not needed, if not needed we should consider removing them.
Certainly, once the new index design is supported by every module, the outdated codes will be removed. I intend to keep them to avoid compiling failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #46: Implements LSM tree index and inverted index
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #46:
URL: https://github.com/apache/skywalking-banyandb/pull/46#discussion_r709310579
##########
File path: api/proto/banyandb/common/v2/common.proto
##########
@@ -34,4 +34,5 @@ message Metadata {
string group = 1;
// name of the entity
string name = 2;
+ uint32 id = 3;
Review comment:
@lujiajing1126 the id will be generated by metadata module. We set it for index rules manually for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org