You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/11/23 15:33:35 UTC
[GitHub] [accumulo-website] DomGarguilo opened a new pull request #251: Typo fixes and minor grammar changes.
DomGarguilo opened a new pull request #251:
URL: https://github.com/apache/accumulo-website/pull/251
Found a few typos as well as some possible spelling changes/improvements while reviewing the Accumulo documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii merged pull request #251: Typo fixes and minor grammar changes.
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #251:
URL: https://github.com/apache/accumulo-website/pull/251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii commented on pull request #251: Typo fixes and minor grammar changes.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #251:
URL: https://github.com/apache/accumulo-website/pull/251#issuecomment-732283272
Thanks for the PR @DomGarguilo . Thank you for your contribution. If you wish to be added as a contributor to https://accumulo.apache.org/people/ , please open a pull request to add yourself at https://github.com/apache/accumulo-website/edit/main/pages/people.md and leave a reference to `apache/accumulo-website#251` in your commit log.
If you intend to be a regular contributor to Accumulo projects, please consider subscribing to our developer mailing list (https://accumulo.apache.org/contact-us/) and introducing yourself. :smiley_cat:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii commented on a change in pull request #251: Typo fixes and minor grammar changes.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #251:
URL: https://github.com/apache/accumulo-website/pull/251#discussion_r528835008
##########
File path: _docs-2/administration/in-depth-install.md
##########
@@ -290,7 +290,7 @@ general.security.credential.provider.paths=jceks://file/path/to/accumulo/conf/ac
```
This configuration will then transparently extract the [instance.secret] from
-the configured KeyStore and alleviates a human readable storage of the sensitive
+the configured KeyStore and elliminates human readable storage of the sensitive
Review comment:
```suggestion
the configured KeyStore and eliminates human readable storage of the sensitive
```
##########
File path: _docs-2/configuration/overview.md
##########
@@ -101,8 +101,8 @@ Accumulo's current configuration can be viewed in the shell using the `config` c
* `config -ns <NAMESPACE>` - view configuration for a specific namespace
* `config -t <TABLE>` - view configuration for a specific table
-Below is example shell output from viewing configuration for the table `foo`. Please note how `table.compaction.major.ratio`
-is set in multiple locations but the value `1.6` set in the `table` scope is used as it has the highest precedence.
+Below is an example shell output from viewing configuration for the table `foo`. Please note how `table.compaction.major.ratio`
+is set in multiple locations but, the value `1.6` set in the `table` scope, is used as it has the highest precedence.
Review comment:
```suggestion
is set in multiple locations, but the value `1.6` set in the `table` scope is used because it has the highest precedence.
```
##########
File path: _docs-2/development/summaries.md
##########
@@ -57,7 +57,7 @@ The following tablet server and table properties configure summarization.
## Permissions
Because summary data may be derived from sensitive data, requesting summary data
-requires a special permission. User must have the table permission
+requires a special permission. A user must have the table permission
Review comment:
```suggestion
requires a special permission. Users must have the table permission
```
##########
File path: _docs-2/security/authorizations.md
##########
@@ -118,7 +118,7 @@ disable the bulk import permission.
For applications serving many users, it is not expected that an Accumulo user
will be created for each application user. In this case an Accumulo user with
-all authorizations needed by any of the applications users must be created. To
+all authorizations needed by all of the application's users must be created. To
Review comment:
```suggestion
all authorizations needed by any of the application's users must be created. To
```
##########
File path: _docs-2/development/sampling.md
##########
@@ -34,11 +34,11 @@ for examples of how to configure a [Sampler] on a table.
Once a table is configured with a [Sampler], all writes after that point will
generate sample data. For data written before sampling was configured, sample
data will not be present. A compaction can be initiated that only compacts the
-files in the table that do not have sample data. The [sampling example][example]
+files in the table that do not have sample data. The [sampling example][example]
Review comment:
```suggestion
files in the table that do not have sample data. The [sampling example][example]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org