You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@deltaspike.apache.org by st...@apache.org on 2011/12/29 10:11:16 UTC
git commit: fix findbugs improvements
Updated Branches:
refs/heads/master cefea5630 -> b786d0e43
fix findbugs improvements
Project: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/commit/b786d0e4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/tree/b786d0e4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/diff/b786d0e4
Branch: refs/heads/master
Commit: b786d0e434212d6b678375a93b5a2a66aee5db7a
Parents: cefea56
Author: Mark Struberg <st...@apache.org>
Authored: Thu Dec 29 10:09:36 2011 +0100
Committer: Mark Struberg <st...@apache.org>
Committed: Thu Dec 29 10:09:36 2011 +0100
----------------------------------------------------------------------
.../deltaspike/core/api/config/ConfigResolver.java | 7 ++++++-
.../deltaspike/core/api/provider/BeanProvider.java | 4 +++-
.../deltaspike/core/api/util/ClassUtils.java | 6 +++++-
.../core/impl/util/ClassDeactivation.java | 2 +-
4 files changed, 15 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/b786d0e4/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/config/ConfigResolver.java
----------------------------------------------------------------------
diff --git a/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/config/ConfigResolver.java b/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/config/ConfigResolver.java
index 51a4063..94ba1e2 100644
--- a/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/config/ConfigResolver.java
+++ b/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/config/ConfigResolver.java
@@ -36,8 +36,13 @@ import javax.enterprise.inject.Typed;
* Resolve the configuration via their well defined ordinals.
*/
@Typed()
-public class ConfigResolver
+public final class ConfigResolver
{
+ private ConfigResolver()
+ {
+ // this is a utility class which doesn't get instantiated.
+ }
+
/**
* The content of this map will get lazily initiated and will hold the
* sorted List of ConfigSources for each WebApp/EAR, etc (thus the
http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/b786d0e4/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/provider/BeanProvider.java
----------------------------------------------------------------------
diff --git a/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/provider/BeanProvider.java b/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/provider/BeanProvider.java
index d1fecb0..e349a94 100644
--- a/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/provider/BeanProvider.java
+++ b/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/provider/BeanProvider.java
@@ -19,6 +19,7 @@
package org.apache.deltaspike.core.api.provider;
import javax.enterprise.context.spi.CreationalContext;
+import javax.enterprise.inject.Typed;
import javax.enterprise.inject.spi.Bean;
import javax.enterprise.inject.spi.BeanManager;
import java.lang.annotation.Annotation;
@@ -31,7 +32,8 @@ import java.util.Set;
*
* @see BeanManagerProvider
*/
-public class BeanProvider
+@Typed()
+public final class BeanProvider
{
private BeanProvider()
{
http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/b786d0e4/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/util/ClassUtils.java
----------------------------------------------------------------------
diff --git a/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/util/ClassUtils.java b/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/util/ClassUtils.java
index 86f79e6..00b527e 100644
--- a/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/util/ClassUtils.java
+++ b/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/api/util/ClassUtils.java
@@ -150,7 +150,11 @@ public abstract class ClassUtils
{
return targetClass.newInstance();
}
- catch (Exception e)
+ catch (InstantiationException e)
+ {
+ //do nothing - it was just a try
+ }
+ catch (IllegalAccessException e)
{
//do nothing - it was just a try
}
http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/b786d0e4/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/util/ClassDeactivation.java
----------------------------------------------------------------------
diff --git a/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/util/ClassDeactivation.java b/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/util/ClassDeactivation.java
index 80bb456..d8e5fd2 100644
--- a/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/util/ClassDeactivation.java
+++ b/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/util/ClassDeactivation.java
@@ -33,7 +33,7 @@ import java.util.logging.Logger;
* Helper methods for {@link ClassDeactivator}
*/
@Typed()
-public class ClassDeactivation
+public final class ClassDeactivation
{
private static final Logger LOG = Logger.getLogger(ClassDeactivation.class.getName());