You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/27 08:08:26 UTC

[GitHub] [hudi] stayrascal opened a new pull request #4917: [MINOR] fix get builtin function issue from Hudi catalog

stayrascal opened a new pull request #4917:
URL: https://github.com/apache/hudi/pull/4917


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   * Fix NPE problem during search Flink builtin function `TO_DATE('xxx')` while enable `Hudi` catalog, because the original logic of `getPartition(ObjectPath tablePath, CatalogPartitionSpec catalogPartitionSpec)` is return null, which will caused NPE problem.
   * 
   ![image](https://user-images.githubusercontent.com/13775334/155873786-12a209b4-982e-4b27-b45f-901e596296a5.png)
   
   
   ## Brief change log
     - *Replace `null` with FunctionNotExistException of getFunction method in HoodieCatalog.java*
     - *Replace `null` with PartitionNotExistException of getPartition method in HoodieCatalog.java*
     - *Add a IT case to test get builtin function*
     - *Change `TableSchema` to `ResolveSchema` in ContinousFileSource.java*
   
   ## Verify this pull request
   
     - *Added integration tests(`testBuiltinFunctionWithCatalog`) in HoodieDataSourceITCase.java*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4917: [MINOR] fix get builtin function issue from Hudi catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4917:
URL: https://github.com/apache/hudi/pull/4917#issuecomment-1053400608


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6359",
       "triggerID" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 10e080b627f60dc5190f2b031f67dc61b85f938a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6359) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4917: [MINOR] fix get builtin function issue from Hudi catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4917:
URL: https://github.com/apache/hudi/pull/4917#issuecomment-1053340863


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6359",
       "triggerID" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 10e080b627f60dc5190f2b031f67dc61b85f938a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6359) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4917: [MINOR] fix get builtin function issue from Hudi catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4917:
URL: https://github.com/apache/hudi/pull/4917#issuecomment-1053337442


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 10e080b627f60dc5190f2b031f67dc61b85f938a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #4917: [MINOR] fix get builtin function issue from Hudi catalog

Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #4917:
URL: https://github.com/apache/hudi/pull/4917


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4917: [MINOR] fix get builtin function issue from Hudi catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4917:
URL: https://github.com/apache/hudi/pull/4917#issuecomment-1053337442


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 10e080b627f60dc5190f2b031f67dc61b85f938a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #4917: [MINOR] fix get builtin function issue from Hudi catalog

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4917:
URL: https://github.com/apache/hudi/pull/4917#issuecomment-1055982909


   @danny0405 : feel free to ask someone else to review if you are occupied w/ other work items. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4917: [MINOR] fix get builtin function issue from Hudi catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4917:
URL: https://github.com/apache/hudi/pull/4917#issuecomment-1053340863


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6359",
       "triggerID" : "10e080b627f60dc5190f2b031f67dc61b85f938a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 10e080b627f60dc5190f2b031f67dc61b85f938a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6359) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org