You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2014/11/14 17:43:20 UTC
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/152
fixes ace editor cutting off viewing code
Jira ticket https://issues.apache.org/jira/browse/COUCHDB-2454
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton 2454-Ace-Document-Editor-cuts-off-very-long-lines-of-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit 8523f2d7b440cb3be51c3f4eecc63b3ad25face5
Author: Michelle Phung <mi...@gmail.com>
Date: 2014-11-14T16:03:45Z
fixes ace editor cutting off viewing code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/152#issuecomment-63368570
changes were made
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/152#issuecomment-63330575
nice suggestions @benkeen ! I've implemented them :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/152#discussion_r20371700
--- Diff: app/addons/fauxton/base.js ---
@@ -133,6 +133,7 @@ function(app, FauxtonAPI, resizeColumns, Components, ZeroClipboard) {
var $selectorList = $('body');
$selectorList.toggleClass('closeMenu');
this.resizeColumns.onResizeHandler();
+ FauxtonAPI.Events.trigger('burger:click');
--- End diff --
Could we put 'burger:click' into constants.js?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/152#discussion_r20373720
--- Diff: app/addons/documents/assets/less/documents.less ---
@@ -100,9 +100,9 @@ button.beautify {
}
#editor-container {
- width: 1316px;
height: 688px;
font-size: 16px;
+ width: 97%;
--- End diff --
This does work, but I don't much like it... :( When resizing the page, the space between the end of the editor and the right side of the window changes. It's a small detail, but I think it should remain consistent.
Instead, it might be nicer to set that to a full 100% here, then add 20px right-padding to the #dashboard-content (or an immediate child if it's not easy to do for this page alone).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/152#discussion_r20371316
--- Diff: app/addons/fauxton/components.js ---
@@ -762,6 +762,15 @@ function(app, FauxtonAPI, ace, spin, ZeroClipboard) {
return 'Your changes have not been saved. Click cancel to return to the document.';
}
});
+
+ $(window).resize(_.debounce( function () {
+ that.editor.resize(true);
+ }, 500));
+
+ this.listenTo(FauxtonAPI.Events, 'burger:click', function () {
+ that.editor.resize(true);
+ });
--- End diff --
Maybe avoid the duplicate code and stick the shared function in a var for re-use.
```javascript
var onResize = _.debounce(function () { that.editor.resize(true); }, 500);
$(window).resize(onResize);
$(window).click(onResize);
```
Tempting to stick 500 in constants.js, too.... but meh, that's probably overkill.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/152#issuecomment-63458958
Great change!
Sorry for being a bit pedantic about this, but please write a description that describes the issue and also references the ticket in Jira (COUCHDB-2454) in the commit message as we are losing the reference to this PR after the merge.
See: https://github.com/apache/couchdb-fauxton/blob/master/CONTRIBUTING.md#guide-to-contributions (`Commit messages should follow the following style`)
+1 after addressing this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/152#issuecomment-63636113
merged as 8a49da5caee4e22d0ea93992352b157ecd1691c7! thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/152#issuecomment-63349609
Other than the extremely minor whitespace things I commented on, this looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fixes ace editor cutting off viewing...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/152#issuecomment-63368760
+1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---