You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/08/11 13:59:56 UTC

[GitHub] [fineract] adamsaghy opened a new pull request, #2505: FINERACT-1670: Rework command source to store dates in UTC

adamsaghy opened a new pull request, #2505:
URL: https://github.com/apache/fineract/pull/2505

   ## Description
   
   Describe the changes made and why they were made.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] galovics commented on a diff in pull request #2505: FINERACT-1670: Rework command source to store dates in UTC

Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2505:
URL: https://github.com/apache/fineract/pull/2505#discussion_r943870313


##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends AbstractPersistableCustom {
     @JoinColumn(name = "maker_id", nullable = false)
     private AppUser maker;
 
-    @Column(name = "made_on_date", nullable = false)
-    private LocalDateTime madeOnDate;
+    /*
+     * Deprecated: Columns and data left untouched to help migration.
+     *
+     * @Column(name = "made_on_date", nullable = false) private LocalDateTime madeOnDate;
+     *
+     * @Column(name = "checked_on_date", nullable = true) private LocalDateTime checkedOnDate;
+     */
+
+    @Column(name = "made_on_utc", nullable = false)

Review Comment:
   Fine for me, no worries. I just like things consistent, I'm not enforcing any type of naming ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] galovics commented on a diff in pull request #2505: FINERACT-1670: Rework command source to store dates in UTC

Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2505:
URL: https://github.com/apache/fineract/pull/2505#discussion_r943739542


##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends AbstractPersistableCustom {
     @JoinColumn(name = "maker_id", nullable = false)
     private AppUser maker;
 
-    @Column(name = "made_on_date", nullable = false)
-    private LocalDateTime madeOnDate;
+    /*
+     * Deprecated: Columns and data left untouched to help migration.
+     *
+     * @Column(name = "made_on_date", nullable = false) private LocalDateTime madeOnDate;
+     *
+     * @Column(name = "checked_on_date", nullable = true) private LocalDateTime checkedOnDate;
+     */
+
+    @Column(name = "made_on_utc", nullable = false)
+    private OffsetDateTime madeOnDate;
+
+    @Column(name = "checked_on_utc")

Review Comment:
   Same as above.



##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends AbstractPersistableCustom {
     @JoinColumn(name = "maker_id", nullable = false)
     private AppUser maker;
 
-    @Column(name = "made_on_date", nullable = false)
-    private LocalDateTime madeOnDate;
+    /*
+     * Deprecated: Columns and data left untouched to help migration.
+     *
+     * @Column(name = "made_on_date", nullable = false) private LocalDateTime madeOnDate;
+     *
+     * @Column(name = "checked_on_date", nullable = true) private LocalDateTime checkedOnDate;
+     */
+
+    @Column(name = "made_on_utc", nullable = false)

Review Comment:
   Since in the native query you're referring to this column as madeOnDateUtc, do you think it would make sense to name it appropriately?
   Instead of `made_on_utc` it could be `made_on_date_utc`.
   Thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] adamsaghy commented on a diff in pull request #2505: FINERACT-1670: Rework command source to store dates in UTC

Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2505:
URL: https://github.com/apache/fineract/pull/2505#discussion_r943746986


##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends AbstractPersistableCustom {
     @JoinColumn(name = "maker_id", nullable = false)
     private AppUser maker;
 
-    @Column(name = "made_on_date", nullable = false)
-    private LocalDateTime madeOnDate;
+    /*
+     * Deprecated: Columns and data left untouched to help migration.
+     *
+     * @Column(name = "made_on_date", nullable = false) private LocalDateTime madeOnDate;
+     *
+     * @Column(name = "checked_on_date", nullable = true) private LocalDateTime checkedOnDate;
+     */
+
+    @Column(name = "made_on_utc", nullable = false)

Review Comment:
   You have eagle eyes. I was wondering change the native query instead. I started this kind of naming convention with all the new fields i have added, like: created_on_utc,
   created_by,...
   
   Basically, i am leaving out the type, like: id, date, ...
   Would you mind if i stick to the column name but would change in the native query the alias?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] adamsaghy commented on a diff in pull request #2505: FINERACT-1670: Rework command source to store dates in UTC

Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2505:
URL: https://github.com/apache/fineract/pull/2505#discussion_r943897282


##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends AbstractPersistableCustom {
     @JoinColumn(name = "maker_id", nullable = false)
     private AppUser maker;
 
-    @Column(name = "made_on_date", nullable = false)
-    private LocalDateTime madeOnDate;
+    /*
+     * Deprecated: Columns and data left untouched to help migration.
+     *
+     * @Column(name = "made_on_date", nullable = false) private LocalDateTime madeOnDate;
+     *
+     * @Column(name = "checked_on_date", nullable = true) private LocalDateTime checkedOnDate;
+     */
+
+    @Column(name = "made_on_utc", nullable = false)

Review Comment:
   Nah.. you are right... I just rename the column... :D



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] adamsaghy commented on a diff in pull request #2505: FINERACT-1670: Rework command source to store dates in UTC

Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2505:
URL: https://github.com/apache/fineract/pull/2505#discussion_r943746986


##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends AbstractPersistableCustom {
     @JoinColumn(name = "maker_id", nullable = false)
     private AppUser maker;
 
-    @Column(name = "made_on_date", nullable = false)
-    private LocalDateTime madeOnDate;
+    /*
+     * Deprecated: Columns and data left untouched to help migration.
+     *
+     * @Column(name = "made_on_date", nullable = false) private LocalDateTime madeOnDate;
+     *
+     * @Column(name = "checked_on_date", nullable = true) private LocalDateTime checkedOnDate;
+     */
+
+    @Column(name = "made_on_utc", nullable = false)

Review Comment:
   You have eagle eyes. I was wondering change the native query instead. I started this kind of naming convention with all the new fields i have added, like: created_on_utc,
   created_by,...
   
   Would you mind if i stick to the column name but would change in the native query the alias?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] galovics merged pull request #2505: FINERACT-1670: Rework command source to store dates in UTC

Posted by GitBox <gi...@apache.org>.
galovics merged PR #2505:
URL: https://github.com/apache/fineract/pull/2505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org