You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/30 03:38:03 UTC

[GitHub] [hudi] yanghua commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

yanghua commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r661106077



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +353,20 @@ private static int deduplicatePartitionPath(JavaSparkContext jsc, String duplica
 
   private static int doBootstrap(JavaSparkContext jsc, String tableName, String tableType, String basePath,

Review comment:
       The original parameter list is not very graceful. I suggest we can only receive `args`, then use a builder to build(extract) the metadata of the bootstrap action. wdyt?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org