You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/11/08 21:30:52 UTC

[Impala-ASF-CR] IMPALA-11005 (part 2): Upgrade Boost library to 1.74.0 for Impala

Wenzhe Zhou has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17996 )

Change subject: IMPALA-11005 (part 2): Upgrade Boost library to 1.74.0 for Impala
......................................................................

IMPALA-11005 (part 2): Upgrade Boost library to 1.74.0 for Impala

There are some header files deprecated in the new version of Boost
library. Need to define BOOST_ALLOW_DEPRECATED_HEADERS in
CMakeLists.txt to avoid compiling errors. Also define
BOOST_BIND_GLOBAL_PLACEHOLDERS to keep current behaviour of boost::bind
and avoid big code changes.

Define exception handler for a new boost::throw_exception() API since
BOOST_NO_EXCEPTIONS is defined in be/CMakeLists.txt and we have to
provide handlers which will be called by codegen'd code.

Revert the code change made by IMPALA-2846 and IMPALA-9571 since the
bug was fixed in Boost 1.74.0.

Testing:
 - Passed core DEBUG build and exhaustive release build.
 - Passed core ASAN build.

Change-Id: I78f32ae3c274274325e7af9e9bc9643814ae346a
---
M be/CMakeLists.txt
M be/src/benchmarks/convert-timestamp-benchmark.cc
M be/src/codegen/llvm-codegen.cc
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/timestamp-value.cc
M be/src/statestore/failure-detector.h
M be/src/util/blocking-queue-test.cc
M be/src/util/condition-variable.h
M be/src/util/filesystem-util.cc
M bin/impala-config.sh
10 files changed, 28 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/17996/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78f32ae3c274274325e7af9e9bc9643814ae346a
Gerrit-Change-Number: 17996
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>