[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #12162: Enhance EncryptAlgorithm and QueryAssistedEncryptAlgorithm

[GitBox <gi...@apache.org>]

taojintianxia commented on a change in pull request #12162:
URL: https://github.com/apache/shardingsphere/pull/12162#discussion_r700664070



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-api/src/main/java/org/apache/shardingsphere/encrypt/spi/EncryptAlgorithm.java
##########
@@ -29,9 +31,10 @@
      * Encode.
      *
      * @param plaintext plaintext
+     * @param encryptContextMap encrypt context map which include keys: database, table and column etc
      * @return ciphertext
      */
-    String encrypt(Object plaintext);
+    String encrypt(Object plaintext, Map<String, String> encryptContextMap);

Review comment:
       what does this and following several maps use for ? and why not final this time




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org