[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3102: GOBBLIN-1259: Implement a Kafka streaming extractor

[GitBox <gi...@apache.org>]

autumnust commented on a change in pull request #3102:
URL: https://github.com/apache/incubator-gobblin/pull/3102#discussion_r486785972



##########
File path: gobblin-core-base/build.gradle
##########
@@ -21,6 +21,7 @@ apply plugin: 'me.champeau.gradle.jmh'
 
 dependencies {
   compile project(":gobblin-api")
+  compile project(":gobblin-metastore")

Review comment:
       What is this module used for ? 

##########
File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/MetricContextUtils.java
##########
@@ -0,0 +1,23 @@
+package org.apache.gobblin.metrics;

Review comment:
       License header missing here

##########
File path: gobblin-modules/gobblin-kafka-common/src/test/java/org/apache/gobblin/metrics/kafka/LoggingPusherTest.java
##########
@@ -40,6 +41,7 @@ public void testKafkaReporter() {
 
     TestAppender testAppender = new TestAppender();
     Logger logger = LogManager.getLogger(LoggingPusher.class.getName());
+    logger.setLevel(Level.INFO);

Review comment:
       is this needed? 

##########
File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/kafka/client/GobblinKafkaConsumerClient.java
##########
@@ -166,6 +167,8 @@ default long committed(KafkaPartition partition) {
     return -1L;
   }
 
+  default void assignAndSeek(List<KafkaPartition> topicPartitions, Map<KafkaPartition, LongWatermark> topicWatermarksMap) { return; }

Review comment:
       is this relevant ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org