You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Alexey Ivanov <a1...@yandex.ru> on 2017/06/08 09:49:05 UTC
IGNITE-5432 fixed
Hi, everyone
I've fixed IgniteMarshallerCacheClassNameConflictTest in
IgniteBinarySimpleNameMapperBasicTestSuite.
Please review it.
pull request:
https://github.com/apache/ignite/pull/2105
master:
http://ci.ignite.apache.org/viewLog.html?buildId=653740&buildTypeId=Ignite20Tests_IgniteBinarySImpleMapperBasic&tab=buildResultsDiv
2105:
http://ci.ignite.apache.org/viewLog.html?buildId=653518&tab=buildResultsDiv&buildTypeId=Ignite20Tests_IgniteBinarySImpleMapperBasic
Alexey Ivanov (a1vanov)
Re: IGNITE-5432 fixed
Posted by Anton Vinogradov <av...@gridgain.com>.
Alexey,
Thanks for interest to Apache Ignite development.
I briefly checked your changes and see commented codelines, does it mean
that PR not ready for review yet?
Also, direct "review request" can help to speedup review process, you can
find tips here:
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-SubmittingforReview
BTW, we have some articles about codestyle and abbreviations.
It will be nice if you'll follow these recomendations
https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
And the main thing, as far as I can see you fixed issue created by
yourself.
Could you please add description explains problem and some comments about
your fix?
On Thu, Jun 8, 2017 at 12:49 PM, Alexey Ivanov <a1...@yandex.ru> wrote:
> Hi, everyone
>
> I've fixed IgniteMarshallerCacheClassNameConflictTest in
> IgniteBinarySimpleNameMapperBasicTestSuite.
>
> Please review it.
>
> pull request:
> https://github.com/apache/ignite/pull/2105
>
> master:
> http://ci.ignite.apache.org/viewLog.html?buildId=653740&buil
> dTypeId=Ignite20Tests_IgniteBinarySImpleMapperBasic&tab=buildResultsDiv
>
> 2105:
> http://ci.ignite.apache.org/viewLog.html?buildId=653518&tab=
> buildResultsDiv&buildTypeId=Ignite20Tests_IgniteBinarySImpleMapperBasic
>
> Alexey Ivanov (a1vanov)
>
>