You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/19 10:56:59 UTC

[GitHub] [spark] Yikun commented on pull request #35557: [SPARK-38244][K8S][BUILD] Upgrade kubernetes-client to 5.12.1

Yikun commented on pull request #35557:
URL: https://github.com/apache/spark/pull/35557#issuecomment-1045990765


   @dongjoon-hyun Thanks for invistigation.
   
   Yes, this might has some behavior changes(especially when specified `spark.kubernetes.context`).
   
   https://github.com/fabric8io/kubernetes-client/blob/677884ca88f3911f9b41ec919db152d441ad2cdd/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/Config.java#L236-L245
   
   ```java
   // v5.12.0
   public static Config autoConfigure(String context) {
     config.autoConfigure = Boolean.TRUE;
     autoConfigure(config, null);
     return autoConfigure(config, context);
   }
   
   
   // v5.12.1
   public static Config autoConfigure(String context) {
     return autoConfigure(config, context);
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org