You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "JanKaul (via GitHub)" <gi...@apache.org> on 2026/08/28 06:49:44 UTC
[PR] test(reader): end-to-end delete-application tests (position, equality, mixed) [iceberg-rust]
JanKaul opened a new pull request, #3087:
URL: https://github.com/apache/iceberg-rust/pull/3087
## Which issue does this PR close?
None — this is additional test coverage.
## What changes are included in this PR?
`ArrowReader` already loads and applies both position and equality deletes, but the existing tests cover the loader / predicate / row-group pieces in isolation. There's no end-to-end coverage (`read()` → assert surviving rows) for scenarios that **combine or stack** delete files.
This adds an `arrow::reader::delete_application` test module with five end-to-end tests:
- a single equality delete removes exactly the matching rows;
- **multiple equality delete files** targeting one data file (keys unioned);
- **multiple position delete files** targeting one data file (positions unioned);
- **mixed** position + equality deletes on the same data file;
- a **fully-deleted** data file yields no rows.
Each test writes a small data file and its delete file(s) to a `TempDir`, reads them through `ArrowReader::read()` with a local-filesystem `FileIO`, and asserts the surviving `id`s.
## Are these changes tested?
Yes — the five new tests pass (`cargo test -p iceberg`). They use only the public reader API (`ArrowReaderBuilder`, `FileScanTask`, `FileScanTaskDeleteFile`, `FileIO::new_with_fs`) and need no external services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test(reader): end-to-end delete-application tests (position, equality, mixed) [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3087:
URL: https://github.com/apache/iceberg-rust/pull/3087#issuecomment-5943264585
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test(reader): end-to-end delete-application tests (position, equality, mixed) [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3087:
URL: https://github.com/apache/iceberg-rust/pull/3087#issuecomment-6135270284
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test(reader): end-to-end delete-application tests (position, equality, mixed) [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3087: test(reader): end-to-end delete-application tests (position, equality, mixed)
URL: https://github.com/apache/iceberg-rust/pull/3087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org