You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/18 12:40:45 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2498: add into_inner to take inner writer out

tustvold commented on code in PR #2498:
URL: https://github.com/apache/arrow-rs/pull/2498#discussion_r949083244


##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -223,6 +223,11 @@ impl<W: Write> ArrowWriter<W> {
         Ok(())
     }
 
+    /// Returns the underlying writer.
+    pub fn into_inner(self) -> W {

Review Comment:
   I think this should either call flush, or mention the need for this in the doc comment. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org