[GitHub] [tvm] mehrdadh commented on a diff in pull request #11808: [microTVM][RVM] Reuse QEMU installation config and fix bug in RVM testing

[GitBox <gi...@apache.org>]

mehrdadh commented on code in PR #11808:
URL: https://github.com/apache/tvm/pull/11808#discussion_r904069314


##########
apps/microtvm/reference-vm/base-box-tool.py:
##########
@@ -360,6 +361,9 @@ def do_build_release_test_vm(
     found_box_line = False
     with open(release_test_vagrantfile, "w") as f:
         for line in lines:
+            # Skip setting version
+            if "config.vm.box_version" in line:

Review Comment:
   because version only used for released boxes, but we are testing this one locally



##########
apps/microtvm/reference-vm/base-box-tool.py:
##########
@@ -360,6 +361,9 @@ def do_build_release_test_vm(
     found_box_line = False
     with open(release_test_vagrantfile, "w") as f:
         for line in lines:
+            # Skip setting version
+            if "config.vm.box_version" in line:

Review Comment:
   because version only used for released boxes, but we are testing locally here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org