You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/01 16:38:08 UTC
[GitHub] [kafka] rhauch opened a new pull request #10238: KAFKA-10340: Proactively close producer when cancelling source tasks
rhauch opened a new pull request #10238:
URL: https://github.com/apache/kafka/pull/10238
**_NOTE: This is targeted to the `2.8` branch (currently frozen), but includes the same commit cherry-picked from `trunk` and originating in #10016 for (KAFKA-10340)[https://issues.apache.org/jira/browse/KAFKA-10340]._**
**_This should be merged only after this issue is approved as a blocker for 2.8.0, or after 2.8.0 is released._**
Close the producer in `WorkerSourceTask` when the latter is cancelled. If the broker do not autocreate the topic, and the connector is not configured to create topics written by the source connector, then the `WorkerSourceTask` main thread will block forever until the topic is created, and will not stop if cancelled or scheduled for shutdown by the worker.
Expanded an existing unit test for the WorkerSourceTask class to ensure that the producer is closed when the task is abandoned, and added a new integration test that guarantees that tasks are still shut down even when their producers are trying to write to topics that do not exist.
Author: Chris Egerton <ch...@confluent.io>
Reviewed: Greg Harris <gr...@confluent.io>, Randall Hauch <rh...@gmail.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rhauch commented on pull request #10238: KAFKA-10340: Backport proactively close producer when cancelling source tasks
Posted by GitBox <gi...@apache.org>.
rhauch commented on pull request #10238:
URL: https://github.com/apache/kafka/pull/10238#issuecomment-832898998
Closed without merging. Instead, I cherry-picked the commit from #10016 to the `2.8` branch now that 2.8.0 is out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rhauch closed pull request #10238: KAFKA-10340: Backport proactively close producer when cancelling source tasks
Posted by GitBox <gi...@apache.org>.
rhauch closed pull request #10238:
URL: https://github.com/apache/kafka/pull/10238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org