You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by li...@apache.org on 2019/12/23 04:02:39 UTC
[dubbo] branch master updated: call Filter.onResponse for backward
compatibility. (#5527)
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new 9cae36e call Filter.onResponse for backward compatibility. (#5527)
9cae36e is described below
commit 9cae36e0f5ae469dcc86853ad440b183bba48712
Author: ken.lj <ke...@gmail.com>
AuthorDate: Mon Dec 23 12:02:25 2019 +0800
call Filter.onResponse for backward compatibility. (#5527)
---
.../src/main/java/org/apache/dubbo/rpc/ListenableFilter.java | 4 +++-
.../java/org/apache/dubbo/rpc/protocol/ProtocolFilterWrapper.java | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/ListenableFilter.java b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/ListenableFilter.java
index f515827..1d75f07 100644
--- a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/ListenableFilter.java
+++ b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/ListenableFilter.java
@@ -17,7 +17,9 @@
package org.apache.dubbo.rpc;
/**
- *
+ * This abstract will be removed soon from one future release.
+ * Please implementing Filter.Listener directly for callback registration,
+ * check the default implementation, see {@link org.apache.dubbo.rpc.filter.ExceptionFilter}, for example.
*/
@Deprecated
public abstract class ListenableFilter implements Filter {
diff --git a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/ProtocolFilterWrapper.java b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/ProtocolFilterWrapper.java
index ba221ed..a5869ef 100644
--- a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/ProtocolFilterWrapper.java
+++ b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/ProtocolFilterWrapper.java
@@ -110,6 +110,8 @@ public class ProtocolFilterWrapper implements Protocol {
} else {
listener.onError(t, invoker, invocation);
}
+ } else {// Deprecated!
+ filter.onResponse(r, invoker, invocation);
}
});
}