You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2022/02/19 14:34:49 UTC

[GitHub] [celix] PengZheng commented on a change in pull request #399: Another tracker improvements preliminary

PengZheng commented on a change in pull request #399:
URL: https://github.com/apache/celix/pull/399#discussion_r810497376



##########
File path: libs/framework/src/service_registry.c
##########
@@ -1124,12 +1044,7 @@ celix_status_t celix_serviceRegistry_addServiceListener(celix_service_registry_t
         event.reference = ref;
         event.type = OSGI_FRAMEWORK_SERVICE_EVENT_REGISTERED;
         listener->serviceChanged(listener->handle, &event);

Review comment:
       Consider when serviceTracker_invokeAddingService returns error, the newly created reference might need to be removed from `registry->serviceReferences`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org