You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/22 14:42:30 UTC
[GitHub] [flink] wuchong commented on a change in pull request #12289: [FLINK-17874][Connectors/HBase]Handling the NPE for hbase-connector
wuchong commented on a change in pull request #12289:
URL: https://github.com/apache/flink/pull/12289#discussion_r429288738
##########
File path: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/util/HBaseTypeUtils.java
##########
@@ -81,13 +81,16 @@ public static Object deserializeToObject(byte[] value, int typeIdx, Charset stri
* Serialize the Java Object to byte array with the given type.
*/
public static byte[] serializeFromObject(Object value, int typeIdx, Charset stringCharset) {
+ if (value == null){
+ return EMPTY_BYTES;
Review comment:
Could you add a dual logic in the `deserializeToObject`? If the input value is EMPTY_BYTES, we can just return null. I guess we will have similar problem in the deserialization side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org