You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/10 00:26:24 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #11366: Allow unset write threshold for state backed iterable coder.

lukecwik commented on a change in pull request #11366: Allow unset write threshold for state backed iterable coder.
URL: https://github.com/apache/beam/pull/11366#discussion_r406545747
 
 

 ##########
 File path: sdks/python/apache_beam/coders/coders.py
 ##########
 @@ -1385,7 +1388,8 @@ def from_runner_api_parameter(payload, components, context):
         components[0],
         read_state=context.iterable_state_read,
         write_state=context.iterable_state_write,
-        write_state_threshold=int(payload))
+        write_state_threshold=int(payload)
 
 Review comment:
   This isn't part of the documentation for the spec for the state backed iterable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services