You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2016/06/02 17:07:52 UTC
Review Request 48176: Changed cache xml property for spark tests to
use new DistributionConfig property
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48176/
-----------------------------------------------------------
Review request for geode, William Markito, Udo Kohlmeyer, and Dan Smith.
Repository: geode
Description
-------
The spark build is currently broken due to an invalid property
Diffs
-----
geode-spark-connector/geode-spark-connector/src/it/java/ittest/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java 1c6a5a2
Diff: https://reviews.apache.org/r/48176/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 48176: Changed cache xml property for spark tests
to use new DistributionConfig property
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48176/#review135970
-----------------------------------------------------------
geode-spark-connector/geode-spark-connector/src/it/java/ittest/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java (line 61)
<https://reviews.apache.org/r/48176/#comment200983>
Yes, I believe you are correct. Fixing it!
- Jason Huynh
On June 2, 2016, 5:07 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48176/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 5:07 p.m.)
>
>
> Review request for geode, William Markito, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The spark build is currently broken due to an invalid property
>
>
> Diffs
> -----
>
> geode-spark-connector/geode-spark-connector/src/it/java/ittest/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java 1c6a5a2
>
> Diff: https://reviews.apache.org/r/48176/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 48176: Changed cache xml property for spark tests
to use new DistributionConfig property
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48176/#review135989
-----------------------------------------------------------
Ship it!
Once CACHE_XML_FILE has referenced the correct DistributedSystemConfigProperties.
- Udo Kohlmeyer
On June 2, 2016, 5:07 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48176/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 5:07 p.m.)
>
>
> Review request for geode, William Markito, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The spark build is currently broken due to an invalid property
>
>
> Diffs
> -----
>
> geode-spark-connector/geode-spark-connector/src/it/java/ittest/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java 1c6a5a2
>
> Diff: https://reviews.apache.org/r/48176/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 48176: Changed cache xml property for spark tests
to use new DistributionConfig property
Posted by Udo Kohlmeyer <uk...@gmail.com>.
> On June 2, 2016, 5:16 p.m., Dan Smith wrote:
> > geode-spark-connector/geode-spark-connector/src/it/java/ittest/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java, line 62
> > <https://reviews.apache.org/r/48176/diff/1/?file=1405059#file1405059line62>
> >
> > Should this use DistributedSystemConfigProperties.CACHE_XML_FILE instead?
Agreed, this should be DistributedSystemConfigProperties.CACHE_XML_FILE.
- Udo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48176/#review135968
-----------------------------------------------------------
On June 2, 2016, 5:07 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48176/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 5:07 p.m.)
>
>
> Review request for geode, William Markito, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The spark build is currently broken due to an invalid property
>
>
> Diffs
> -----
>
> geode-spark-connector/geode-spark-connector/src/it/java/ittest/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java 1c6a5a2
>
> Diff: https://reviews.apache.org/r/48176/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 48176: Changed cache xml property for spark tests
to use new DistributionConfig property
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48176/#review135968
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
geode-spark-connector/geode-spark-connector/src/it/java/ittest/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java (line 61)
<https://reviews.apache.org/r/48176/#comment200979>
Should this use DistributedSystemConfigProperties.CACHE_XML_FILE instead?
- Dan Smith
On June 2, 2016, 5:07 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48176/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 5:07 p.m.)
>
>
> Review request for geode, William Markito, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The spark build is currently broken due to an invalid property
>
>
> Diffs
> -----
>
> geode-spark-connector/geode-spark-connector/src/it/java/ittest/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java 1c6a5a2
>
> Diff: https://reviews.apache.org/r/48176/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>