You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/11/28 18:16:50 UTC
Re: Review Request 54099: Used environment to pass flags to launch
helper.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54099/#review157079
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Nov. 26, 2016, 11:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54099/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2016, 11:47 p.m.)
>
>
> Review request for mesos, Gilbert Song and Kevin Klues.
>
>
> Bugs: MESOS-6648
> https://issues.apache.org/jira/browse/MESOS-6648
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of doing that just for command environment variables, this
> patch does it consistently by using environment variables to pass
> launch helper flags. This will be more secure.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 9b33495d9babc3ee489a8712fe1977746c41043f
>
> Diff: https://reviews.apache.org/r/54099/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>