[jira] Resolved: (DIR-99) Bug in codesize.sh, & improvment

["Alex Karasulu (JIRA)" <di...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/DIR-99?page=history ]
     
Alex Karasulu resolved DIR-99:
------------------------------

    Resolution: Fixed

Committed in 151105



> Bug in codesize.sh, & improvment
> --------------------------------
>
>          Key: DIR-99
>          URL: http://issues.apache.org/jira/browse/DIR-99
>      Project: Directory
>         Type: Bug
>   Components: General
>  Environment: Unix/Linux
>     Reporter: Emmanuel Lecharny
>     Assignee: Alex Karasulu
>     Priority: Trivial

>
> The codesize script does not give the good count : if two java files have the same name in two different directories, the latest replace the previous one, thus the count is lost.
> I suggest to replace the followin lines :
>         mkdir temp
>         for file in `find $trunk -type f -regex '.*\.java'`; do
>                 cp $file temp;
>         done;
>         cd temp;
>         lines=`wc -l * | grep total | awk '{print $1}'`;
>         cd ../
>         rm -rf temp;
> by this one :
>         lines=$(for file in $(find $trunk -type f -name "*.java"); do wc -l $file; done | awk '{sum += $col} END {print sum}')
> Note that no more copy are made, leading to a small improvment in performance, and in disk occupation ;-)
> The result is :
> lines of code in ./ldap/trunk = 99208      (was 94685)
> lines of code in ./sandbox/trunk = 3630
> lines of code in ./protocol/trunk = 583
> lines of code in ./dns/trunk = 4242
> lines of code in ./authx/trunk = 8325      (was 8109)
> lines of code in ./naming/trunk = 15950    (was 15867)
> lines of code in ./network/trunk = 14538   (was 14360)
> lines of code in ./apacheds/trunk = 44670
> lines of code in ./ntp/trunk = 1618
> lines of code in ./asn1/trunk = 26796      (was 26752)
> lines of code in ./kerberos/trunk = 13292  (was 13083)
> lines of code in ./changepw/trunk = 2291
> lines of code in ./dhcp/trunk = 4911
> lines of code in ./apseda/trunk = 15177
> Total: 255231  (was 249978)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira