You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "Alok Lal (JIRA)" <ji...@apache.org> on 2015/02/11 08:33:11 UTC

[jira] [Commented] (RANGER-243) AsyncAuditProvider thread should exit without delay on shutdown

    [ https://issues.apache.org/jira/browse/RANGER-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315721#comment-14315721 ] 

Alok Lal commented on RANGER-243:
---------------------------------

Can you upload the patch to the Review please?  Either that or there is some other problem because the review does not show any diffs.

> AsyncAuditProvider thread should exit without delay on shutdown
> ---------------------------------------------------------------
>
>                 Key: RANGER-243
>                 URL: https://issues.apache.org/jira/browse/RANGER-243
>             Project: Ranger
>          Issue Type: Bug
>            Reporter: Madhan Neethiraj
>            Assignee: Madhan Neethiraj
>         Attachments: 0001-RANGER-243-AsyncAuditProvider-thread-should-exit-wit.patch
>
>
> Currently, the thread created by AsyncAuditProvider can wait upto 30 seconds before exiting during shutdown. This behavior is due to the mechanism used to notify the audit thread to quit - a flag set by the thread that signals to quit.
> Update this implementation to use Thread.interrupt() call, which will result in InterruptedException in the audit thread. This will ensure that the audit thread will not delay shutdown of the process (like namenode, hbase-servers, hive-server, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Commented] (RANGER-243) AsyncAuditProvider thread should exit without delay on shutdown

Posted by Madhan Neethiraj <mn...@hortonworks.com>.
Alok,

Not sure what's wrong with the review site. Can you please review using the patch uploaded in the bug?

Thanks,
Madhan



> On Feb 10, 2015, at 11:33 PM, Alok Lal (JIRA) <ji...@apache.org> wrote:
> 
> 
>    [ https://issues.apache.org/jira/browse/RANGER-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315721#comment-14315721 ] 
> 
> Alok Lal commented on RANGER-243:
> ---------------------------------
> 
> Can you upload the patch to the Review please?  Either that or there is some other problem because the review does not show any diffs.
> 
>> AsyncAuditProvider thread should exit without delay on shutdown
>> ---------------------------------------------------------------
>> 
>>                Key: RANGER-243
>>                URL: https://issues.apache.org/jira/browse/RANGER-243
>>            Project: Ranger
>>         Issue Type: Bug
>>           Reporter: Madhan Neethiraj
>>           Assignee: Madhan Neethiraj
>>        Attachments: 0001-RANGER-243-AsyncAuditProvider-thread-should-exit-wit.patch
>> 
>> 
>> Currently, the thread created by AsyncAuditProvider can wait upto 30 seconds before exiting during shutdown. This behavior is due to the mechanism used to notify the audit thread to quit - a flag set by the thread that signals to quit.
>> Update this implementation to use Thread.interrupt() call, which will result in InterruptedException in the audit thread. This will ensure that the audit thread will not delay shutdown of the process (like namenode, hbase-servers, hive-server, etc).
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)