You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/22 12:58:27 UTC
[GitHub] [dubbo-go-hessian2] AlexStocks opened a new issue #193: Add: go struct for jdk8 time
AlexStocks opened a new issue #193:
URL: https://github.com/apache/dubbo-go-hessian2/issues/193
<!-- Please only use this template for submitting enhancement requests -->
**What would you like to be added**:
Add go structs for the following time classes in jdk8:
- java.time.OffsetDateTime
- java.time.ZoneOffset
- java.time.OffsetTime
- java.time.ZoneDateTime
**Why is this needed**:
these classes are very popular in jdk8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on issue #193: Add: go struct for jdk8 time
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #193:
URL: https://github.com/apache/dubbo-go-hessian2/issues/193#issuecomment-633323493
> > > it seems there are going to add more and more java classes to support
> >
> >
> > agree with u. firstly, we can move the exception outside. And then we add the other java classes.
>
> I have changed my opinion, moving the exception outside need user to change the source code. so adding the time class mapping in this project may be better, but not load it default, asking user to init to load when required, because it will not be used for most users and projects.
ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on issue #193: Add: go struct for jdk8 time
Posted by GitBox <gi...@apache.org>.
wongoo commented on issue #193:
URL: https://github.com/apache/dubbo-go-hessian2/issues/193#issuecomment-633322132
> > it seems there are going to add more and more java classes to support
>
> agree with u. firstly, we can move the exception outside. And then we add the other java classes.
I have changed my opinion, moving the exception outside need user to change the source code. so adding the time class mapping in this project may be better, but not load it default, asking user to init to load when required, because it will not be used for most users and projects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on issue #193: Add: go struct for jdk8 time
Posted by GitBox <gi...@apache.org>.
wongoo commented on issue #193:
URL: https://github.com/apache/dubbo-go-hessian2/issues/193#issuecomment-632998590
it seems there are going to add more and more java classes to support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks closed issue #193: Add: go struct for jdk8 time
Posted by GitBox <gi...@apache.org>.
AlexStocks closed issue #193:
URL: https://github.com/apache/dubbo-go-hessian2/issues/193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on issue #193: Add: go struct for jdk8 time
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #193:
URL: https://github.com/apache/dubbo-go-hessian2/issues/193#issuecomment-632679844
to [willson-chen](github.com/willson-chen)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on issue #193: Add: go struct for jdk8 time
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #193:
URL: https://github.com/apache/dubbo-go-hessian2/issues/193#issuecomment-632998368
> suggest add java clas support in other project， eg：
>
> * dubbogo/hessian-java-ext-basic
> * dubbogo/hessian-java-ext-exception
> * dubbogo/hessian-java-ext-time
>
> @AlexStocks @fangyincheng @hxmhlt
why? If so, we should move the exception too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on issue #193: Add: go struct for jdk8 time
Posted by GitBox <gi...@apache.org>.
wongoo commented on issue #193:
URL: https://github.com/apache/dubbo-go-hessian2/issues/193#issuecomment-632997914
suggest add java clas support in other project， eg：
- dubbogo/hessian-java-ext-basic
- dubbogo/hessian-java-ext-exception
- dubbogo/hessian-java-ext-time
@AlexStocks @fangyincheng @hxmhlt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on issue #193: Add: go struct for jdk8 time
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #193:
URL: https://github.com/apache/dubbo-go-hessian2/issues/193#issuecomment-633019828
> it seems there are going to add more and more java classes to support
agree with u. firstly, we can move the exception outside. And then we add the other java classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org