You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/06 09:31:15 UTC
[GitHub] [skywalking-showcase] wu-sheng commented on a diff in pull request #20: Update oap/ui images
wu-sheng commented on code in PR #20:
URL: https://github.com/apache/skywalking-showcase/pull/20#discussion_r843718036
##########
Makefile.in:
##########
@@ -26,8 +26,8 @@ TAG ?= $(shell git rev-parse --short HEAD)
ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss:7.10.0
-SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap:74fbc3d8ecce103eeefc2a7e52b3d369b0b2c956
-SW_ROCKET_BOT_IMAGE ?= ghcr.io/apache/skywalking/ui:74fbc3d8ecce103eeefc2a7e52b3d369b0b2c956
+SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap:b670ea6031d0e23c8947459ccb9c02ee435ca9f5
+SW_ROCKET_BOT_IMAGE ?= ghcr.io/apache/skywalking/ui:b670ea6031d0e23c8947459ccb9c02ee435ca9f5
Review Comment:
```suggestion
SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap:4e750e69fbe34a9d6e87b4db7dda955a335736db
SW_ROCKET_BOT_IMAGE ?= ghcr.io/apache/skywalking/ui:4e750e69fbe34a9d6e87b4db7dda955a335736db
```
If e2e could pass, I will update this to latest again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org