You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/02 02:28:45 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2381: [Enhancement] Method gets and sets a value of a ConcurrentHashMap in a racy manner
Alonexc opened a new issue, #2381:
URL: https://github.com/apache/incubator-eventmesh/issues/2381
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/consumer/ConsumerManager.java line 104
analysis and explanation:
This method retrieves the value of a key from a ConcurrentHashMap, where the value is itself a collection. It checks this value for null, and if it is so, creates a new collection and places it in the map. This may cause thread race conditions where two threads overwrite each other's values.
### Describe the solution you'd like
Sould be using ConcurrentHashMap.putIfAbsent(K, V) instead
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #2381: [Enhancement] Method gets and sets a value of a ConcurrentHashMap in a racy manner
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #2381: [Enhancement] Method gets and sets a value of a ConcurrentHashMap in a racy manner
URL: https://github.com/apache/incubator-eventmesh/issues/2381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on issue #2381: [Enhancement] Method gets and sets a value of a ConcurrentHashMap in a racy manner
Posted by GitBox <gi...@apache.org>.
jonyangx commented on issue #2381:
URL: https://github.com/apache/incubator-eventmesh/issues/2381#issuecomment-1336096935
I want to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org