You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/01/15 01:36:36 UTC
[GitHub] carbondata pull request #1800: [HOTFIX] Add exception catch in testcase when...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1800
[HOTFIX] Add exception catch in testcase when create store failed
This PR only modify the testcase to add exception handling logic when create store failed for test.
- [X] Any interfaces changed?
No
- [X] Any backward compatibility impacted?
No
- [X] Document update required?
No
- [X] Testing done
Re run all test
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata createstore_exception
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1800.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1800
----
commit 177d6d26c58e0d06c2cdb93d4a03a27472884559
Author: Jacky Li <ja...@...>
Date: 2018-01-06T12:28:44Z
[CARBONDATA-1992] Remove partitionId in CarbonTablePath
In CarbonTablePath, there is a deprecated partition id which is always 0, it should be removed to avoid confusion.
This closes #1765
commit c57ce30535851fb8a91bab9e8eaa62c461c29905
Author: Jacky Li <ja...@...>
Date: 2018-01-15T01:34:03Z
add exception
----
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1609/
---
[GitHub] carbondata issue #1800: [HOTFIX] Fix concurrent testcase random failure
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1800
retest this please
---
[GitHub] carbondata pull request #1800: [HOTFIX] Fix concurrent testcase random failu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1800
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1800
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2876/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1800
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2879/
---
[GitHub] carbondata issue #1800: [HOTFIX] Fix concurrent testcase random failure
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2903/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1536/
---
[GitHub] carbondata issue #1800: [HOTFIX] Fix concurrent testcase random failure
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1800
verified, LGTM
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1800
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2885/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2772/
---
[GitHub] carbondata pull request #1800: [HOTFIX] Fix concurrent testcase random failu...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1800#discussion_r162003508
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/IUDConcurrentTest.scala ---
@@ -73,34 +85,50 @@ class IUDConcurrentTest extends QueryTest with BeforeAndAfterAll {
dropTable()
}
+ override def beforeEach(): Unit = {
+ Global.compactionRunning = false
--- End diff --
Please change compactionRunning to insertoverwriteRunning
---
[GitHub] carbondata issue #1800: [HOTFIX] Fix concurrent testcase random failure
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1674/
---
[GitHub] carbondata issue #1800: [HOTFIX] Fix concurrent testcase random failure
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2878/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1539/
---
[GitHub] carbondata issue #1800: [HOTFIX] Fix concurrent testcase random failure
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1670/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2844/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2769/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1542/
---
[GitHub] carbondata issue #1800: [HOTFIX] Fix concurrent testcase random failure
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1645/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1547/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1800
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2931/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1800
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2875/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1800
retest this please
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1800
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2874/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2780/
---
[GitHub] carbondata issue #1800: [HOTFIX] Add exception catch in testcase when create...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2775/
---
[GitHub] carbondata issue #1800: [HOTFIX] Fix concurrent testcase random failure
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1800
retest this please
---
[GitHub] carbondata issue #1800: [HOTFIX] Fix concurrent testcase random failure
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1800
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2906/
---