You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/05 08:10:16 UTC
[GitHub] [flink] kl0u commented on a change in pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
kl0u commented on a change in pull request #13531:
URL: https://github.com/apache/flink/pull/13531#discussion_r499415647
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -615,7 +615,12 @@ public IntervalJoined(
* {@link org.apache.flink.streaming.api.environment.StreamExecutionEnvironment#setStreamTimeCharacteristic(org.apache.flink.streaming.api.TimeCharacteristic)}
*
* @param size The size of the window.
+ *
+ * @deprecated Please use {@link #windowAll(WindowAssigner)} with either {@link
+ * TumblingEventTimeWindows} or {@link TumblingProcessingTimeWindows}. For more information,
Review comment:
I think that was copied from the `timeWindowAll` :P
The deprecation message should mention `window()`, not `windowAll()`.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -633,7 +638,12 @@ public IntervalJoined(
* {@link org.apache.flink.streaming.api.environment.StreamExecutionEnvironment#setStreamTimeCharacteristic(org.apache.flink.streaming.api.TimeCharacteristic)}
*
* @param size The size of the window.
+ *
+ * @deprecated Please use {@link #windowAll(WindowAssigner)} with either {@link
+ * SlidingEventTimeWindows} or {@link SlidingProcessingTimeWindows}. For more information,
+ * see the deprecation notice on {@link TimeCharacteristic}
*/
+ @Deprecated
Review comment:
Same as above.
##########
File path: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/KeyedStream.scala
##########
@@ -231,11 +231,36 @@ class KeyedStream[T, K](javaStream: KeyedJavaStream[T, K]) extends DataStream[T]
* [[StreamExecutionEnvironment.setStreamTimeCharacteristic()]]
*
* @param size The size of the window.
+ *
+ * @deprecated Please use [[windowAll()]] with either [[TumblingEventTimeWindows]] or
+ * [[TumblingProcessingTimeWindows]]. For more information, see the deprecation
+ * notice on [[org.apache.flink.streaming.api.TimeCharacteristic]].
*/
+ @deprecated
Review comment:
Same as in the java classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org