[GitHub] [hudi] danny0405 commented on a change in pull request #4847: [HUDI-3042] Refactoring clustering executors

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #4847:
URL: https://github.com/apache/hudi/pull/4847#discussion_r810755690



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java
##########
@@ -200,4 +215,65 @@ protected boolean isWorkloadProfileNeeded() {
 
   protected abstract Iterator<List<WriteStatus>> handleUpdate(String partitionPath, String fileId,
       Iterator<HoodieRecord<T>> recordItr) throws IOException;
+
+  protected HoodieWriteMetadata<HoodieData<WriteStatus>> executeClustering(HoodieClusteringPlan clusteringPlan) {
+    HoodieInstant instant = HoodieTimeline.getReplaceCommitRequestedInstant(instantTime);

Review comment:
       The `BaseCommitActionExecutor` responsibilities are a bit confusing, it handles regular writing process such as `insert`, `upsert` and with this path `clustering`, then what about the `compaction`?
   
   Should we make a new base class for table services then ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org