You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mdespriee <gi...@git.apache.org> on 2017/09/01 08:01:19 UTC
[GitHub] spark pull request #17461: [SPARK-20082][ml] LDA incremental model learning
Github user mdespriee commented on a diff in the pull request:
https://github.com/apache/spark/pull/17461#discussion_r136519055
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -180,6 +179,29 @@ private[clustering] trait LDAParams extends Params with HasFeaturesCol with HasM
@Since("1.6.0")
def getOptimizer: String = $(optimizer)
+
+ /**
+ * For Online optimizer only (currently): [[optimizer]] = "online".
+
+ * An initial model to be used as a starting point for the learning, instead of a random
+ * initialization. Provide the path to a serialized trained LDAModel.
--- End diff --
Hi @hhbyyh
After a quick look, it seems ok to follow this. I'll try to merge locally and see how it fits. I'll keep you updated. Do you think #18610 will be merged shortly ? (cc @yanboliang)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org