You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by gi...@git.apache.org on 2017/07/19 18:13:05 UTC
[GitHub] vrahane commented on a change in pull request #432: Adding LED, button and pin values to bsp.h
vrahane commented on a change in pull request #432: Adding LED, button and pin values to bsp.h
URL: https://github.com/apache/mynewt-core/pull/432#discussion_r128324834
##########
File path: hw/bsp/nrf51dk/include/bsp/bsp.h
##########
@@ -37,8 +37,44 @@ extern uint8_t _ram_start;
#define RAM_SIZE 0x8000
/* LED pins */
-#define LED_BLINK_PIN (21)
-#define LED_2 (22)
+#define LED_1 (17)
+#define LED_2 (18)
+#define LED_3 (19)
+#define LED_4 (20)
+#define LED_BLINK_PIN (LED_1)
Review comment:
I did not cross verify everything with the schematic but LED_BLINK_PIN was 21 earlier and now it's getting changed to 17. Is this intentional ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services